Sign upLogin

emmercm/igir

View on GitHub
Star
src/modules/candidates/candidatePatchGenerator.ts

Summary

Maintainability
C
1 day
Test Coverage

Function buildPatchedParentsForReleaseCandidate has 83 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private async buildPatchedParentsForReleaseCandidate(
    dat: DAT,
    unpatchedReleaseCandidate: ReleaseCandidate,
    crcToPatches: Map<string, Patch[]>,
  ): Promise<[Parent, ReleaseCandidate[]][] | undefined> {
Severity: Major
Found in src/modules/candidates/candidatePatchGenerator.ts - About 3 hrs to fix

    Function romsWithFiles has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

              unpatchedReleaseCandidate.getRomsWithFiles().map(async (romWithFiles) => {
            // Apply the new filename
            let rom = romWithFiles.getRom();
            let inputFile = romWithFiles.getInputFile();
            let outputFile = romWithFiles.getOutputFile();
    Severity: Minor
    Found in src/modules/candidates/candidatePatchGenerator.ts - About 1 hr to fix

      Function build has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private async build(
    dat: DAT,
    parentsToCandidates: Map<Parent, ReleaseCandidate[]>,
    crcToPatches: Map<string, Patch[]>,
  ): Promise<Map<Parent, ReleaseCandidate[]>> {
      Severity: Minor
      Found in src/modules/candidates/candidatePatchGenerator.ts - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            return patches.reduce((map, patch) => {
      const key = patch.getCrcBefore();
      if (!map.has(key)) {
        map.set(key, [patch]);
      } else {
        Severity: Major
        Found in src/modules/candidates/candidatePatchGenerator.ts and 1 other location - About 2 hrs to fix
        src/types/indexedFiles.ts on lines 161..169

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 93.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                      this.progressBar.logTrace(
                `${dat.getNameShort()}: ${inputFile.toString()}: patch candidate generated: ${outputFile.toString()}`,
              );
        Severity: Major
        Found in src/modules/candidates/candidatePatchGenerator.ts and 2 other locations - About 55 mins to fix
        src/modules/candidates/candidateArchiveFileHasher.ts on lines 106..108
        src/modules/candidates/candidatePreferer.ts on lines 90..92

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 8 locations. Consider refactoring.
        Open

            if (parentsToCandidates.size === 0) {
      this.progressBar.logTrace(`${dat.getNameShort()}: no parents to make patched candidates for`);
      return parentsToCandidates;
    }
        Severity: Major
        Found in src/modules/candidates/candidatePatchGenerator.ts and 7 other locations - About 40 mins to fix
        src/modules/candidates/candidateArchiveFileHasher.ts on lines 41..44
        src/modules/candidates/candidateCombiner.ts on lines 36..39
        src/modules/candidates/candidateExtensionCorrector.ts on lines 49..52
        src/modules/candidates/candidatePostProcessor.ts on lines 29..32
        src/modules/candidates/candidatePreferer.ts on lines 30..33
        src/modules/dats/datScanner.ts on lines 459..462
        src/modules/fixdatCreator.ts on lines 56..61

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status