Sign upLogin

emmercm/igir

View on GitHub
Star
src/modules/candidates/candidatePostProcessor.ts

Summary

Maintainability
A
2 hrs
Test Coverage

Function process has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  process(
    dat: DAT,
    parentsToCandidates: Map<Parent, ReleaseCandidate[]>,
  ): Map<Parent, ReleaseCandidate[]> {
    if (parentsToCandidates.size === 0) {
Severity: Minor
Found in src/modules/candidates/candidatePostProcessor.ts - About 1 hr to fix

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

        if (parentsToCandidates.size === 0) {
      this.progressBar.logTrace(`${dat.getNameShort()}: no parents, so no candidates to process`);
      return parentsToCandidates;
    }
    Severity: Major
    Found in src/modules/candidates/candidatePostProcessor.ts and 7 other locations - About 40 mins to fix
    src/modules/candidates/candidateArchiveFileHasher.ts on lines 41..44
    src/modules/candidates/candidateCombiner.ts on lines 36..39
    src/modules/candidates/candidateExtensionCorrector.ts on lines 49..52
    src/modules/candidates/candidatePatchGenerator.ts on lines 33..36
    src/modules/candidates/candidatePreferer.ts on lines 30..33
    src/modules/dats/datScanner.ts on lines 459..462
    src/modules/fixdatCreator.ts on lines 56..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 13 locations. Consider refactoring.
    Open

      constructor(options: Options, progressBar: ProgressBar) {
    super(progressBar, CandidatePostProcessor.name);
    this.options = options;
  }
    Severity: Major
    Found in src/modules/candidates/candidatePostProcessor.ts and 12 other locations - About 35 mins to fix
    src/modules/candidates/candidateCombiner.ts on lines 20..23
    src/modules/candidates/candidateMergeSplitValidator.ts on lines 18..21
    src/modules/candidates/candidatePreferer.ts on lines 16..19
    src/modules/dats/datFilter.ts on lines 15..18
    src/modules/dats/datMergerSplitter.ts on lines 18..21
    src/modules/dats/datParentInferrer.ts on lines 15..18
    src/modules/dir2DatCreator.ts on lines 20..23
    src/modules/directoryCleaner.ts on lines 22..25
    src/modules/fixdatCreator.ts on lines 24..27
    src/modules/reportGenerator.ts on lines 16..19
    src/modules/roms/romIndexer.ts on lines 24..27
    src/modules/statusGenerator.ts on lines 15..18

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status