Sign upLogin

emory-libraries/eulfedora

View on GitHub
Star

Showing 75 of 182 total issues

Function force_bytes has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def force_bytes(s, encoding='utf-8'):
    if isinstance(s, bytes):
        if encoding == 'utf-8':
            return s
        else:
Severity: Minor
Found in eulfedora/util.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function render has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def render(self, context):
        try:
            return self.fedora_access.render(context)
        except PermissionDenied:
            if self.permission_denied is not None:
Severity: Minor
Found in eulfedora/templatetags/fedora.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function datastream_lastmodified has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

def datastream_lastmodified(request, pid, dsid, repo=None,
Severity: Major
Found in eulfedora/views.py - About 50 mins to fix

    Function addRelationship has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def addRelationship(self, pid, subject, predicate, object, isLiteral=False,
    Severity: Minor
    Found in eulfedora/api.py - About 45 mins to fix

      Function _raw_datastream has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def _raw_datastream(request, pid, dsid, repo=None, headers=None,
      Severity: Minor
      Found in eulfedora/views.py - About 45 mins to fix

        Function __get__ has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def __get__(self, obj, objtype):
        if obj is None:
            return self

        #  if related object has already been cached, use the cached copy
        Severity: Minor
        Found in eulfedora/models.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getDatastreamDissemination has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def getDatastreamDissemination(self, pid, dsID, asOfDateTime=None, stream=False,
        Severity: Minor
        Found in eulfedora/api.py - About 45 mins to fix

          Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def __init__(self, relation, type=None, ns_prefix=None, rdf_type=None,
          Severity: Minor
          Found in eulfedora/models.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                        if 'ObjectExistsException' in rf.detail or \
                              'already exists in the registry; the object can\'t be re-created' in rf.detail:
                                if self.verbosity > 1:
                                    self.stdout.write("Fixture %s has already been loaded" % f)
                            elif 'ObjectValidityException' in rf.detail:
            Severity: Major
            Found in eulfedora/management/commands/syncrepo.py - About 45 mins to fix

              Function datastream_etag has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def datastream_etag(request, pid, dsid, repo=None,
              Severity: Minor
              Found in eulfedora/views.py - About 45 mins to fix

                Function raw_datastream has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                def raw_datastream(request, pid, dsid, repo=None, headers=None,
                Severity: Minor
                Found in eulfedora/views.py - About 45 mins to fix

                  Function purgeDatastream has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def purgeDatastream(self, pid, dsID, startDT=None, endDT=None, logMessage=None,
                  Severity: Minor
                  Found in eulfedora/api.py - About 45 mins to fix

                    Function purgeRelationship has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def purgeRelationship(self, pid, subject, predicate, object, isLiteral=False,
                    Severity: Minor
                    Found in eulfedora/api.py - About 45 mins to fix

                      Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          def __init__(self, obj, dest_repo, verify=False, progress_bar=None,
                      Severity: Minor
                      Found in eulfedora/syncutil.py - About 45 mins to fix

                        Function find_statements has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            def find_statements(self, query, language='spo', type='triples', flush=None,
                        Severity: Minor
                        Found in eulfedora/api.py - About 35 mins to fix

                          Function export has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              def export(self, pid, context=None, format=None, encoding=None,
                          Severity: Minor
                          Found in eulfedora/api.py - About 35 mins to fix

                            Function modifyObject has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                def modifyObject(self, pid, label, ownerId, state, logMessage=None):
                            Severity: Minor
                            Found in eulfedora/api.py - About 35 mins to fix

                              Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  def __init__(self, root=None, username=None, password=None, request=None,
                              Severity: Minor
                              Found in eulfedora/server.py - About 35 mins to fix

                                Function findObjects has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                    def findObjects(self, query=None, terms=None, pid=True, chunksize=None, session_token=None):
                                Severity: Minor
                                Found in eulfedora/api.py - About 35 mins to fix

                                  Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                      def __init__(self, obj, id, label, objtype=xmlmap.XmlObject, **kwargs):
                                  Severity: Minor
                                  Found in eulfedora/models.py - About 35 mins to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language