Sign upLogin

emory-libraries/eulfedora

View on GitHub
Star

Showing 182 of 182 total issues

Function __init__ has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def __init__(self, response, content=None):
        # init params:
        #  response = HttpResponse with the error information
        #  content = optional content of the response body, if it needed to be read
        #            to determine what kind of exception to raise
Severity: Minor
Found in eulfedora/util.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    widgets = ['Download: ', progressbar.widgets.Percentage(), ' ',
               progressbar.widgets.Bar(), ' ', progressbar.widgets.ETA(),
               ' ', progressbar.widgets.FileTransferSpeed()]
Severity: Major
Found in scripts/download-test.py and 3 other locations - About 1 hr to fix
scripts/download-test.py on lines 25..27
scripts/upload-test.py on lines 24..26
scripts/upload-test.py on lines 53..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function _store_api_info has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _store_api_info(self, sender, time_taken=0, method=None, url=None,
Severity: Major
Found in eulfedora/debug_panel.py - About 1 hr to fix

    Function sync_object has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def sync_object(src_obj, dest_repo, export_context='migrate',
    Severity: Major
    Found in eulfedora/syncutil.py - About 1 hr to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          widgets = ['Upload: ', progressbar.widgets.Percentage(), ' ',
               progressbar.widgets.Bar(), ' ', progressbar.widgets.ETA(),
               ' ', progressbar.widgets.FileTransferSpeed()]
      Severity: Major
      Found in scripts/upload-test.py and 3 other locations - About 1 hr to fix
      scripts/download-test.py on lines 25..27
      scripts/download-test.py on lines 56..58
      scripts/upload-test.py on lines 53..55

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          widgets = ['Upload: ', progressbar.widgets.Percentage(), ' ',
               progressbar.widgets.Bar(), ' ', progressbar.widgets.ETA(),
               ' ', progressbar.widgets.FileTransferSpeed()]
      Severity: Major
      Found in scripts/upload-test.py and 3 other locations - About 1 hr to fix
      scripts/download-test.py on lines 25..27
      scripts/download-test.py on lines 56..58
      scripts/upload-test.py on lines 24..26

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          widgets = ['Download: ', progressbar.widgets.Percentage(), ' ',
               progressbar.widgets.Bar(), ' ', progressbar.widgets.ETA(),
               ' ', progressbar.widgets.FileTransferSpeed()]
      Severity: Major
      Found in scripts/download-test.py and 3 other locations - About 1 hr to fix
      scripts/download-test.py on lines 56..58
      scripts/upload-test.py on lines 24..26
      scripts/upload-test.py on lines 53..55

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function force_bytes has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      def force_bytes(s, encoding='utf-8'):
    if isinstance(s, bytes):
        if encoding == 'utf-8':
            return s
        else:
      Severity: Minor
      Found in eulfedora/util.py - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function render has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def render(self, context):
        try:
            return self.fedora_access.render(context)
        except PermissionDenied:
            if self.permission_denied is not None:
      Severity: Minor
      Found in eulfedora/templatetags/fedora.py - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function datastream_lastmodified has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def datastream_lastmodified(request, pid, dsid, repo=None,
      Severity: Major
      Found in eulfedora/views.py - About 50 mins to fix

        Function addRelationship has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def addRelationship(self, pid, subject, predicate, object, isLiteral=False,
        Severity: Minor
        Found in eulfedora/api.py - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def getObjectHistory(self, pid):
        '''Get the history for an object in XML format.

        :param pid: object pid
        :rtype: :class:`requests.models.Response`
          Severity: Minor
          Found in eulfedora/api.py and 1 other location - About 45 mins to fix
          eulfedora/api.py on lines 278..291

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 35.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function _raw_datastream has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def _raw_datastream(request, pid, dsid, repo=None, headers=None,
          Severity: Minor
          Found in eulfedora/views.py - About 45 mins to fix

            Function __get__ has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                def __get__(self, obj, objtype):
        if obj is None:
            return self

        #  if related object has already been cached, use the cached copy
            Severity: Minor
            Found in eulfedora/models.py - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getDatastreamDissemination has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def getDatastreamDissemination(self, pid, dsID, asOfDateTime=None, stream=False,
            Severity: Minor
            Found in eulfedora/api.py - About 45 mins to fix

              Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def __init__(self, relation, type=None, ns_prefix=None, rdf_type=None,
              Severity: Minor
              Found in eulfedora/models.py - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                            if 'ObjectExistsException' in rf.detail or \
                              'already exists in the registry; the object can\'t be re-created' in rf.detail:
                                if self.verbosity > 1:
                                    self.stdout.write("Fixture %s has already been loaded" % f)
                            elif 'ObjectValidityException' in rf.detail:
                Severity: Major
                Found in eulfedora/management/commands/syncrepo.py - About 45 mins to fix

                  Function datastream_etag has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  def datastream_etag(request, pid, dsid, repo=None,
                  Severity: Minor
                  Found in eulfedora/views.py - About 45 mins to fix

                    Function raw_datastream has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    def raw_datastream(request, pid, dsid, repo=None, headers=None,
                    Severity: Minor
                    Found in eulfedora/views.py - About 45 mins to fix

                      Function purgeDatastream has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          def purgeDatastream(self, pid, dsID, startDT=None, endDT=None, logMessage=None,
                      Severity: Minor
                      Found in eulfedora/api.py - About 45 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language