Sign upLogin

emotionLoop/visualCaptcha-npm

View on GitHub
Star

Showing 8 of 8 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            fs.exists( audioFilePath, function( exists ) {
                if ( exists ) {
                    mimeType = mime.getType( audioFilePath );

                    // Set the appropriate mime type
Severity: Major
Found in visualCaptcha.js and 1 other location - About 1 day to fix
visualCaptcha.js on lines 234..272

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 328.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            fs.exists( imageFilePath, function( exists ) {
                if ( exists ) {
                    mimeType = mime.getType( imageFilePath );

                    // Set the appropriate mime type
Severity: Major
Found in visualCaptcha.js and 1 other location - About 1 day to fix
visualCaptcha.js on lines 162..200

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 328.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function streamImage has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    streamImage: function( index, response, isRetina ) {
        var fs = require( 'fs' ),
            imageOption = this.getImageOptionAtIndex( index ),
            imageFileName = imageOption ? imageOption.path : '',// If there's no imageOption, we set the file name as empty
            imageFilePath = __dirname + '/images/' + imageFileName,
Severity: Minor
Found in visualCaptcha.js - About 1 hr to fix

    Function streamAudio has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        streamAudio: function( response, fileType ) {
        var fs = require( 'fs' ),
            mime = require( 'mime' ),
            audioOption = this.getValidAudioOption(),
            audioFileName = audioOption ? audioOption.path : '',// If there's no audioOption, we set the file name as empty
    Severity: Minor
    Found in visualCaptcha.js - About 1 hr to fix

      Function generate has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          generate: function( numberOfOptions ) {
        var visualCaptchaSession = this.session[ this.namespace ],
            imageValues = [];

        // Avoid the next IF failing if a string with a number is sent
      Severity: Minor
      Found in visualCaptcha.js - About 1 hr to fix

        Function exports has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        module.exports = function( session, namespace, defaultImages, defaultAudios ) {
    var captcha = {};

    // Throw an error if no session object is passed
    if ( typeof session !== 'object' || ! session ) {
        Severity: Minor
        Found in visualCaptcha.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function streamAudio has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            streamAudio: function( response, fileType ) {
        var fs = require( 'fs' ),
            mime = require( 'mime' ),
            audioOption = this.getValidAudioOption(),
            audioFileName = audioOption ? audioOption.path : '',// If there's no audioOption, we set the file name as empty
        Severity: Minor
        Found in visualCaptcha.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function streamImage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            streamImage: function( index, response, isRetina ) {
        var fs = require( 'fs' ),
            imageOption = this.getImageOptionAtIndex( index ),
            imageFileName = imageOption ? imageOption.path : '',// If there's no imageOption, we set the file name as empty
            imageFilePath = __dirname + '/images/' + imageFileName,
        Severity: Minor
        Found in visualCaptcha.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language