Sign upLogin

emsa16/chat-server

View on GitHub
Star

Showing 8 of 8 total issues

Function parseBroadcastMessage has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

async function parseBroadcastMessage(ws, message) {
    let obj;

    try {
        obj = JSON.parse(message);
Severity: Minor
Found in server.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File server.js has 273 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Server using Websockets and Express
 * Support for broadcast and echo subprotocols
 */
"use strict";
Severity: Minor
Found in server.js - About 2 hrs to fix

    Function parseBroadcastMessage has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    async function parseBroadcastMessage(ws, message) {
    let obj;

    try {
        obj = JSON.parse(message);
    Severity: Major
    Found in server.js - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              case "message":
            if ('message' in obj.params && obj.params.message) {
                broadcastExcept(ws, obj.params.message);
            } else {
                console.log("Empty message");
      Severity: Major
      Found in server.js and 1 other location - About 1 hr to fix
      server.js on lines 213..220

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              case "nick":
            if ('nickname' in obj.params && obj.params.nickname) {
                changeNick(ws, obj.params.nickname);
            } else {
                console.log("Missing nickname");
      Severity: Major
      Found in server.js and 1 other location - About 1 hr to fix
      server.js on lines 221..228

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function verifyClient has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      async function verifyClient(info, callback) {
    if ("sec-websocket-protocol" in info.req.headers &&
        info.req.headers['sec-websocket-protocol'] == "broadcast") {
        if (limitClientToUrl && limitClientToUrl !== info.origin) {
            return callback(false, 403, 'Unauthorized: forbidden origin', '');
      Severity: Minor
      Found in server.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function manageBroadCastConn has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function manageBroadCastConn(ws, request) {
    console.log(
        `Connection received. Adding client using '${ws.protocol}' (total: ${wss.clients.size}).`
    );
      Severity: Minor
      Found in server.js - About 1 hr to fix

        Function start has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function start(wsPort,
    wsServerUrl,
    wsLimitClientTo,
    authMod,
    dbMod,
        Severity: Minor
        Found in server.js - About 45 mins to fix
          Severity
          Category
          Status
          Source
          Language