Sign upLogin

emsk/redmine-notifier

View on GitHub
Star

Showing 5 of 5 total issues

File index.js has 561 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

(() => {
  const isMac = process.platform === 'darwin';
  const defaultFetchIntervalSec = 600;
Severity: Major
Found in app/index.js - About 1 day to fix

    Function initMenu has 68 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        initMenu() {
      const appMenu = Menu.buildFromTemplate([
        {
          label: 'Edit',
          submenu: [
    Severity: Major
    Found in app/index.js - About 2 hrs to fix

      Function initEventListener has 63 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          initEventListener() {
      document.getElementById('save-button').addEventListener('click', () => {
        const notifier = this._notifiers[this._currentNotifierIndex];
        notifier.readScreenSettings();
      Severity: Major
      Found in app/index.js - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              if (isMac) {
        this._iconFilePath = `${__dirname}/images/${blackIconFilename24}`;
        this._notificationIconFilePath = `${__dirname}/images/${blackIconFilename24Notification}`;
      } else {
        Severity: Minor
        Found in app/index.js and 1 other location - About 50 mins to fix
        app/index.js on lines 432..435

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              } else {
        this._iconFilePath = `${__dirname}/images/${colorIconFilename24}`;
        this._notificationIconFilePath = `${__dirname}/images/${colorIconFilename24Notification}`;
      }
        Severity: Minor
        Found in app/index.js and 1 other location - About 50 mins to fix
        app/index.js on lines 429..432

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language