Sign upLogin

encharm/http-master

View on GitHub
Star

Showing 71 of 71 total issues

Function exports has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

module.exports = function LetsEncrypt(commService, master, worker, moduleConfig, config) {
Severity: Minor
Found in modules/letsencrypt.js - About 35 mins to fix

    Function getRegexpIfNeeded has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    function getRegexpIfNeeded(str, specialCh, optionalEnding) {
  if (typeof str == 'string') {
    var m = str.match(/^\^(.*)\$?$/);
    if (m) {
      return new XRegExp('^' + m[1] + (optionalEnding?('(?:'+optionalEnding+')?'):'') +  '$');
    Severity: Minor
    Found in src/DispatchTable.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function setupDi has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    function setupDi() {
  var self = this;
  var di = this.di = new DI();
  di.onMissing = function(name) {
    var m;
    Severity: Minor
    Found in src/HttpMaster.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function preprocessPortConfig has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    function preprocessPortConfig(config, cb) {
  var self = this;
  if (config.ssl) {

    var loadsToDo = [];
    Severity: Minor
    Found in src/HttpMaster.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                      return cb(null);
    Severity: Major
    Found in src/certScanner.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                        return cb();
      Severity: Major
      Found in src/certScanner.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return cb(err);
        Severity: Major
        Found in src/certScanner.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return cb();
          Severity: Major
          Found in src/certScanner.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                                return cb();
            Severity: Major
            Found in src/certScanner.js - About 30 mins to fix

              Function init has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              HttpMaster.prototype.init = function(config, initDone) {
  var self = this;
  var workers = this.workers;

  function actualInit(config) {
              Severity: Minor
              Found in src/HttpMaster.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function RedirectMiddleware has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              module.exports = function RedirectMiddleware() {
  return {
    requestHandler: function(req, res, next, target) {
      // skip for websockets
      if(req.upgrade) { return next(); }
              Severity: Minor
              Found in modules/middleware/redirect.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language