Sign upLogin

enclose-io/compiler

View on GitHub
Star
current/deps/v8/tools/turbolizer/src/turbo-visualizer.ts

Summary

Maintainability
F
1 wk
Test Coverage

Function onload has 115 lines of code (exceeds 25 allowed). Consider refactoring.
Open

window.onload = function () {
  let multiview: GraphMultiView = null;
  let disassemblyView: DisassemblyView = null;
  let sourceViews: Array<CodeView> = [];
  let selectionBroker: SelectionBroker = null;
Severity: Major
Found in current/deps/v8/tools/turbolizer/src/turbo-visualizer.ts - About 4 hrs to fix

    Function loadFile has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function loadFile(txtRes: string) {
    sourceTabs.clearTabsAndContent();
    disassemblyTabs.clearTabsAndContent();
    // If the JSON isn't properly terminated, assume compiler crashed and
    // add best-guess empty termination
    Severity: Major
    Found in current/deps/v8/tools/turbolizer/src/turbo-visualizer.ts - About 2 hrs to fix

      Function onload has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

      window.onload = function () {
  let multiview: GraphMultiView = null;
  let disassemblyView: DisassemblyView = null;
  let sourceViews: Array<CodeView> = [];
  let selectionBroker: SelectionBroker = null;
      Severity: Minor
      Found in current/deps/v8/tools/turbolizer/src/turbo-visualizer.ts - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function initializeUploadHandlers has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function initializeUploadHandlers() {
    // The <input> form #upload-helper with type file can't be a picture.
    // We hence keep it hidden, and forward the click from the picture
    // button #upload.
    document.getElementById("upload").addEventListener("click", e => {
      Severity: Minor
      Found in current/deps/v8/tools/turbolizer/src/turbo-visualizer.ts - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        window.onload = function () {
  let multiview: GraphMultiView = null;
  let disassemblyView: DisassemblyView = null;
  let sourceViews: Array<CodeView> = [];
  let selectionBroker: SelectionBroker = null;
        Severity: Major
        Found in current/deps/v8/tools/turbolizer/src/turbo-visualizer.ts and 1 other location - About 1 wk to fix
        lts/deps/v8/tools/turbolizer/src/turbo-visualizer.ts on lines 15..148

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 1333.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status