Sign upLogin

enclose-io/compiler

View on GitHub
Star
current/tools/inspector_protocol/check_protocol_compatibility.py

Summary

Maintainability
F
1 mo
Test Coverage

File check_protocol_compatibility.py has 378 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python
# Copyright (c) 2011 Google Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are
Severity: Minor
Found in current/tools/inspector_protocol/check_protocol_compatibility.py - About 5 hrs to fix

    Function main has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

    def main():
    if not self_test():
        sys.stderr.write("Self-test failed")
        return 1
    Severity: Minor
    Found in current/tools/inspector_protocol/check_protocol_compatibility.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function normalize_types has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    def normalize_types(obj, domain_name, types):
    if isinstance(obj, list):
        for item in obj:
            normalize_types(item, domain_name, types)
    elif isinstance(obj, dict):
    Severity: Minor
    Found in current/tools/inspector_protocol/check_protocol_compatibility.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function compare_types has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    def compare_types(context, kind, type_1, type_2, types_map_1, types_map_2, depth, errors, reverse):
    if depth > 5:
        return

    base_type_1 = type_1["type"]
    Severity: Minor
    Found in current/tools/inspector_protocol/check_protocol_compatibility.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function compare_types has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def compare_types(context, kind, type_1, type_2, types_map_1, types_map_2, depth, errors, reverse):
    Severity: Major
    Found in current/tools/inspector_protocol/check_protocol_compatibility.py - About 1 hr to fix

      Function compare_params_list has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def compare_params_list(context, kind, params_1, params_2, types_map_1, types_map_2, depth, errors, reverse):
      Severity: Major
      Found in current/tools/inspector_protocol/check_protocol_compatibility.py - About 1 hr to fix

        Function compare_commands has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def compare_commands(domain_name, command_1, command_2, types_map_1, types_map_2, errors, reverse):
        Severity: Major
        Found in current/tools/inspector_protocol/check_protocol_compatibility.py - About 50 mins to fix

          Function compare_events has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def compare_events(domain_name, event_1, event_2, types_map_1, types_map_2, errors, reverse):
          Severity: Major
          Found in current/tools/inspector_protocol/check_protocol_compatibility.py - About 50 mins to fix

            Function compare_params_list has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            def compare_params_list(context, kind, params_1, params_2, types_map_1, types_map_2, depth, errors, reverse):
    for name in params_1:
        param_1 = params_1[name]
        if name not in params_2:
            if "optional" not in param_1:
            Severity: Minor
            Found in current/tools/inspector_protocol/check_protocol_compatibility.py - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function compare_domains has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def compare_domains(domain_1, domain_2, types_map_1, types_map_2, errors, reverse):
            Severity: Minor
            Found in current/tools/inspector_protocol/check_protocol_compatibility.py - About 45 mins to fix

              Function extract_type has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              def extract_type(typed_object, types_map, errors):
    if "type" in typed_object:
        result = {"id": "<transient>", "type": typed_object["type"]}
        if typed_object["type"] == "object":
            result["properties"] = []
              Severity: Minor
              Found in current/tools/inspector_protocol/check_protocol_compatibility.py - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function self_test has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              def self_test():
    def create_test_schema_1():
        return [
            {
                "domain": "Network",
              Severity: Minor
              Found in current/tools/inspector_protocol/check_protocol_compatibility.py - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function compare_domains has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              def compare_domains(domain_1, domain_2, types_map_1, types_map_2, errors, reverse):
    domain_name = domain_1["domain"]
    commands_1 = named_list_to_map(domain_1, "commands", "name")
    commands_2 = named_list_to_map(domain_2, "commands", "name")
    for name in commands_1:
              Severity: Minor
              Found in current/tools/inspector_protocol/check_protocol_compatibility.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 4 locations. Consider refactoring.
              Open

              Severity: Major
              Found in current/tools/inspector_protocol/check_protocol_compatibility.py and 3 other locations - About 1 mo to fix
              current/deps/v8/third_party/inspector_protocol/check_protocol_compatibility.py on lines 0..488
              lts/deps/v8/third_party/inspector_protocol/check_protocol_compatibility.py on lines 0..488
              lts/tools/inspector_protocol/check_protocol_compatibility.py on lines 0..488

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 2857.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status