enclose-io/compiler

View on GitHub
lts/deps/v8/tools/gen-inlining-tests.py

Summary

Maintainability
F
3 wks
Test Coverage

Function printtest has a Cognitive Complexity of 96 (exceeds 5 allowed). Consider refactoring.
Open

def printtest(flags):
  """Print a test case. Takes a couple of boolean flags, on which the
  printed Javascript code depends."""

  assert all(isinstance(flag, bool) for flag in flags)
Severity: Minor
Found in lts/deps/v8/tools/gen-inlining-tests.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File gen-inlining-tests.py has 437 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python

# Copyright 2016 the V8 project authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
Severity: Minor
Found in lts/deps/v8/tools/gen-inlining-tests.py - About 6 hrs to fix

    Function printtest has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def printtest(flags):
      """Print a test case. Takes a couple of boolean flags, on which the
      printed Javascript code depends."""
    
      assert all(isinstance(flag, bool) for flag in flags)
    Severity: Minor
    Found in lts/deps/v8/tools/gen-inlining-tests.py - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

        if (tryReturns and tryThrows and
            (catchWithLocal or endReturnLocal or deopt or anyAlternative)):
          return
        # We don't do any alternative if we do a finally.
        if doFinally and anyAlternative: return
      Severity: Major
      Found in lts/deps/v8/tools/gen-inlining-tests.py - About 40 mins to fix

        Avoid too many return statements within this function.
        Open

          if doFinally and anyAlternative: return
        Severity: Major
        Found in lts/deps/v8/tools/gen-inlining-tests.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            if endReturnLocal and not (tryResultToLocal or catchWithLocal): return
          Severity: Major
          Found in lts/deps/v8/tools/gen-inlining-tests.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return
            Severity: Major
            Found in lts/deps/v8/tools/gen-inlining-tests.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                if doFinally and deopt: return
              Severity: Major
              Found in lts/deps/v8/tools/gen-inlining-tests.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                  if tryFirstReturns and not (tryReturns and tryThrows): return
                Severity: Major
                Found in lts/deps/v8/tools/gen-inlining-tests.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return
                  Severity: Major
                  Found in lts/deps/v8/tools/gen-inlining-tests.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return
                    Severity: Major
                    Found in lts/deps/v8/tools/gen-inlining-tests.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          return
                      Severity: Major
                      Found in lts/deps/v8/tools/gen-inlining-tests.py - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                          if finallyReturns and finallyThrows: return
                        Severity: Major
                        Found in lts/deps/v8/tools/gen-inlining-tests.py - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                            if catchReturns and catchThrows: return
                          Severity: Major
                          Found in lts/deps/v8/tools/gen-inlining-tests.py - About 30 mins to fix

                            Identical blocks of code found in 2 locations. Consider refactoring.
                            Open

                            Severity: Major
                            Found in lts/deps/v8/tools/gen-inlining-tests.py and 1 other location - About 3 wks to fix
                            current/deps/v8/tools/gen-inlining-tests.py on lines 0..568

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 2261.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status