enclose-io/compiler

File mb_unittest.py has 542 lines of code (exceeds 250 allowed). Consider refactoring.

Open

#!/usr/bin/python
# Copyright 2016 the V8 project authors. All rights reserved.
# Copyright 2015 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

UnitTest has 24 functions (exceeds 20 allowed). Consider refactoring.

Open

class UnitTest(unittest.TestCase):
  def fake_mbw(self, files=None, win32=False):
    mbw = FakeMBW(win32=win32)
    mbw.files.setdefault(mbw.default_config, TEST_CONFIG)
    mbw.files.setdefault(

Function check has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

  def check(self, args, mbw=None, files=None, out=None, err=None, ret=None):

Identical blocks of code found in 2 locations. Consider refactoring.

Open

class FakeMBW(mb.MetaBuildWrapper):
  def __init__(self, win32=False):
    super(FakeMBW, self).__init__()

    # Override vars for test portability.

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def test_gen(self):
    mbw = self.fake_mbw()
    self.check(['gen', '-c', 'debug_goma', '//out/Default', '-g', '/goma'],
               mbw=mbw, ret=0)
    self.assertMultiLineEqual(mbw.files['/fake_src/out/Default/args.gn'],

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def test_multiple_phases(self):
    # Check that not passing a --phase to a multi-phase builder fails.
    mbw = self.check(['lookup', '-m', 'fake_master', '-b', 'fake_multi_phase'],
                     ret=1)
    self.assertIn('Must specify a build --phase', mbw.out)

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def test_analyze_handles_way_too_many_results(self):
    too_many_files = ', '.join(['"//foo:foo%d"' % i for i in range(4 * 1024)])
    files = {'/tmp/in.json': '''{\
               "files": ["foo/foo_unittest.cc"],
               "test_targets": ["foo_unittests"],

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def test_analyze(self):
    files = {'/tmp/in.json': '''{\
               "files": ["foo/foo_unittest.cc"],
               "test_targets": ["foo_unittests"],
               "additional_compile_targets": ["all"]

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def test_analyze_handles_other_toolchains(self):
    files = {'/tmp/in.json': '''{\
               "files": ["foo/foo_unittest.cc"],
               "test_targets": ["foo_unittests"],
               "additional_compile_targets": ["all"]

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def test_analyze_optimizes_compile_for_all(self):
    files = {'/tmp/in.json': '''{\
               "files": ["foo/foo_unittest.cc"],
               "test_targets": ["foo_unittests"],
               "additional_compile_targets": ["all"]

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def fake_mbw(self, files=None, win32=False):
    mbw = FakeMBW(win32=win32)
    mbw.files.setdefault(mbw.default_config, TEST_CONFIG)
    mbw.files.setdefault(
      mbw.ToAbsPath('//testing/buildbot/gn_isolate_map.pyl'),

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def check(self, args, mbw=None, files=None, out=None, err=None, ret=None):
    if not mbw:
      mbw = self.fake_mbw(files)

    actual_ret = mbw.Main(args)

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def test_isolate(self):
    files = {
      '/fake_src/out/Default/toolchain.ninja': "",
      '/fake_src/testing/buildbot/gn_isolate_map.pyl': (
          "{'base_unittests': {"

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def test_multiple_isolate_maps(self):
    files = {
      '/tmp/swarming_targets': 'cc_perftests\n',
      '/fake_src/testing/buildbot/gn_isolate_map.pyl': (
          "{'cc_perftests': {"

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def test_gen_args_file_mixins(self):
    mbw = self.fake_mbw()
    self.check(['gen', '-m', 'fake_master', '-b', 'fake_args_file',
                '//out/Debug'], mbw=mbw, ret=0)

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def test_gen_swarming_script(self):
    files = {
      '/tmp/swarming_targets': 'cc_perftests\n',
      '/fake_src/testing/buildbot/gn_isolate_map.pyl': (
          "{'cc_perftests': {"

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def test_help(self):
    orig_stdout = sys.stdout
    try:
      sys.stdout = StringIO.StringIO()
      self.assertRaises(SystemExit, self.check, ['-h'])

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def test_gen_swarming(self):
    files = {
      '/tmp/swarming_targets': 'base_unittests\n',
      '/fake_src/testing/buildbot/gn_isolate_map.pyl': (
          "{'base_unittests': {"

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

class FakeFile(object):
  def __init__(self, files):
    self.name = '/tmp/file'
    self.buf = ''
    self.files = files

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def test_duplicate_isolate_maps(self):
    files = {
      '/tmp/swarming_targets': 'cc_perftests\n',
      '/fake_src/testing/buildbot/gn_isolate_map.pyl': (
          "{'cc_perftests': {"

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def test_gen_fails(self):
    mbw = self.fake_mbw()
    mbw.Call = lambda cmd, env=None, buffer_output=True: (1, '', '')
    self.check(['gen', '-c', 'debug_goma', '//out/Default'], mbw=mbw, ret=1)

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def test_buildbucket(self):
    mbw = self.fake_mbw()
    mbw.files[mbw.default_config] = TRYSERVER_CONFIG
    self.check(['gerrit-buildbucket-config'], mbw=mbw,

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def test_recursive_lookup(self):
    files = {
        '/fake_src/build/args/fake.gn': (
          'enable_doom_melon = true\n'
          'enable_antidoom_banana = true\n'

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def test_run(self):
    files = {
      '/fake_src/testing/buildbot/gn_isolate_map.pyl': (
          "{'base_unittests': {"
          "  'label': '//base:base_unittests',"

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def test_validate(self):
    mbw = self.fake_mbw()
    self.check(['validate'], mbw=mbw, ret=0)

• Read up
  Read up