Sign upLogin

enclose-io/compiler

View on GitHub
Star
lts/deps/v8/tools/release/search_related_commits.py

Summary

Maintainability
F
1 wk
Test Coverage

Function _search_related_commits has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

def _search_related_commits(
    git_working_dir, start_hash, until, separator, verbose=False):

  if separator:
    commits_between = _find_commits_inbetween(
Severity: Minor
Found in lts/deps/v8/tools/release/search_related_commits.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function main has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

def main(options):
    all_related_commits = search_all_related_commits(
        options.git_dir,
        options.of[0],
        options.until[0],
Severity: Minor
Found in lts/deps/v8/tools/release/search_related_commits.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _search_related_commits has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def _search_related_commits(
Severity: Minor
Found in lts/deps/v8/tools/release/search_related_commits.py - About 35 mins to fix

    Function search_all_related_commits has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def search_all_related_commits(
    Severity: Minor
    Found in lts/deps/v8/tools/release/search_related_commits.py - About 35 mins to fix

      Avoid too many return statements within this function.
      Open

        return hits
      Severity: Major
      Found in lts/deps/v8/tools/release/search_related_commits.py - About 30 mins to fix

        Function search_all_related_commits has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        def search_all_related_commits(
    git_working_dir, start_hash, until, separator, verbose=False):

  all_commits_raw = _find_commits_inbetween(
      start_hash, until, git_working_dir, verbose)
        Severity: Minor
        Found in lts/deps/v8/tools/release/search_related_commits.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        Severity: Major
        Found in lts/deps/v8/tools/release/search_related_commits.py and 1 other location - About 1 wk to fix
        current/deps/v8/tools/release/search_related_commits.py on lines 0..221

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 1164.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status