Sign upLogin

enclose-io/compiler

View on GitHub
Star
lts/deps/v8/tools/sanitizers/sancov_formatter.py

Summary

Maintainability
F
3 wks
Test Coverage

File sancov_formatter.py has 313 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python
# Copyright 2016 the V8 project authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
Severity: Minor
Found in lts/deps/v8/tools/sanitizers/sancov_formatter.py - About 3 hrs to fix

    Function main has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    def main(args=None):
  parser = argparse.ArgumentParser()
  # TODO(machenbach): Make this required and deprecate the default.
  parser.add_argument('--build-dir',
                      default=os.path.join(BASE_DIR, 'out', 'Release'),
    Severity: Minor
    Found in lts/deps/v8/tools/sanitizers/sancov_formatter.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function process_symbolizer_output has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    def process_symbolizer_output(output, build_dir):
  """Post-process llvm symbolizer output.

  Excludes files outside the v8 checkout or given in exclusion list above
  from further processing. Drops the character index in each line.
    Severity: Minor
    Found in lts/deps/v8/tools/sanitizers/sancov_formatter.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function merge_covered_line_results has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def merge_covered_line_results(data, results):
  """Merge multiprocessing results for covered lines.

  The data is mutated, the results are merged into it in place.
    Severity: Minor
    Found in lts/deps/v8/tools/sanitizers/sancov_formatter.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

          return 1
    Severity: Major
    Found in lts/deps/v8/tools/sanitizers/sancov_formatter.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        return 0
      Severity: Major
      Found in lts/deps/v8/tools/sanitizers/sancov_formatter.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return 1
        Severity: Major
        Found in lts/deps/v8/tools/sanitizers/sancov_formatter.py - About 30 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          Severity: Major
          Found in lts/deps/v8/tools/sanitizers/sancov_formatter.py and 1 other location - About 2 wks to fix
          current/deps/v8/tools/sanitizers/sancov_formatter.py on lines 0..459

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 1957.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status