Sign upLogin

enclose-io/compiler

View on GitHub
Star
lts/deps/v8/tools/tracing/proto-converter/proto-to-json.ts

Summary

Maintainability
F
6 days
Test Coverage

Function main has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

async function main() {
  const root = new Root();
  const { resolvePath } = root;
  const numDirectoriesToStrip = 2;
  let initialOrigin: string|null;
Severity: Minor
Found in lts/deps/v8/tools/tracing/proto-converter/proto-to-json.ts - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function main has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function main() {
  const root = new Root();
  const { resolvePath } = root;
  const numDirectoriesToStrip = 2;
  let initialOrigin: string|null;
Severity: Major
Found in lts/deps/v8/tools/tracing/proto-converter/proto-to-json.ts - About 2 hrs to fix

    Function parseArgValue has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    function parseArgValue(arg: any) : any {
  if (arg.jsonValue) {
    return JSON.parse(arg.jsonValue);
  }
  if (typeof arg.stringValue !== 'undefined') {
    Severity: Minor
    Found in lts/deps/v8/tools/tracing/proto-converter/proto-to-json.ts - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

        return uint64AsHexString(arg.pointerValue);
    Severity: Major
    Found in lts/deps/v8/tools/tracing/proto-converter/proto-to-json.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return typeof arg.doubleValue === 'string' ?
        arg.doubleValue : Number(arg.doubleValue);
      Severity: Major
      Found in lts/deps/v8/tools/tracing/proto-converter/proto-to-json.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return arg.boolValue;
        Severity: Major
        Found in lts/deps/v8/tools/tracing/proto-converter/proto-to-json.ts - About 30 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          async function main() {
  const root = new Root();
  const { resolvePath } = root;
  const numDirectoriesToStrip = 2;
  let initialOrigin: string|null;
          Severity: Major
          Found in lts/deps/v8/tools/tracing/proto-converter/proto-to-json.ts and 1 other location - About 4 days to fix
          current/deps/v8/tools/tracing/proto-converter/proto-to-json.ts on lines 75..130

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 687.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          function parseArgValue(arg: any) : any {
  if (arg.jsonValue) {
    return JSON.parse(arg.jsonValue);
  }
  if (typeof arg.stringValue !== 'undefined') {
          Severity: Major
          Found in lts/deps/v8/tools/tracing/proto-converter/proto-to-json.ts and 1 other location - About 1 day to fix
          current/deps/v8/tools/tracing/proto-converter/proto-to-json.ts on lines 43..67

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 228.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          const flatten = <T>(a: T[], b: T[]) => { a.push(...b); return a; }
          Severity: Major
          Found in lts/deps/v8/tools/tracing/proto-converter/proto-to-json.ts and 1 other location - About 1 hr to fix
          current/deps/v8/tools/tracing/proto-converter/proto-to-json.ts on lines 28..28

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 68.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          function parseIntOrThrow(int: string) {
  if (BigInt(int) > Number.MAX_SAFE_INTEGER) {
    throw new Error("Loss of int precision");
  }
  return Number(int);
          Severity: Minor
          Found in lts/deps/v8/tools/tracing/proto-converter/proto-to-json.ts and 1 other location - About 40 mins to fix
          current/deps/v8/tools/tracing/proto-converter/proto-to-json.ts on lines 32..37

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status