Sign upLogin

enclose-io/compiler

View on GitHub
Star
lts/deps/v8/tools/turbolizer/src/disassembly-view.ts

Summary

Maintainability
F
1 mo
Test Coverage

Function constructor has 204 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  constructor(parentId, broker: SelectionBroker) {
    super(parentId, broker);
    const view = this;
    const ADDRESS_STYLE = {
      associateData: (text, fragment: HTMLElement) => {
Severity: Major
Found in lts/deps/v8/tools/turbolizer/src/disassembly-view.ts - About 1 day to fix

    Function constructor has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
    Open

      constructor(parentId, broker: SelectionBroker) {
    super(parentId, broker);
    const view = this;
    const ADDRESS_STYLE = {
      associateData: (text, fragment: HTMLElement) => {
    Severity: Minor
    Found in lts/deps/v8/tools/turbolizer/src/disassembly-view.ts - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File disassembly-view.ts has 352 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // Copyright 2015 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import { PROF_COLS, UNICODE_BLOCK } from "../src/constants";
    Severity: Minor
    Found in lts/deps/v8/tools/turbolizer/src/disassembly-view.ts - About 4 hrs to fix

      Function processLine has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
      Open

        processLine(line) {
    const view = this;
    let fragments = super.processLine(line);

    // Add profiling data per instruction if available.
      Severity: Minor
      Found in lts/deps/v8/tools/turbolizer/src/disassembly-view.ts - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function processLine has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        processLine(line) {
    const view = this;
    let fragments = super.processLine(line);

    // Add profiling data per instruction if available.
      Severity: Minor
      Found in lts/deps/v8/tools/turbolizer/src/disassembly-view.ts - About 1 hr to fix

        Function associateData has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              associateData: (text, fragment: HTMLElement) => {
        const matches = text.match(/(?<address>0?x?[0-9a-fA-F]{8,16})(?<addressSpace>\s+)(?<offset>[0-9a-f]+)(?<offsetSpace>\s*)/);
        const offset = Number.parseInt(matches.groups["offset"], 16);
        const instructionKind = view.sourceResolver.getInstructionKindForPCOffset(offset);
        fragment.dataset.instructionKind = instructionKind;
        Severity: Minor
        Found in lts/deps/v8/tools/turbolizer/src/disassembly-view.ts - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                      for (let i = 0; i < PROF_COLS.length; i++) {
              if (perc === PROF_COLS[i].perc) {
                col = PROF_COLS[i].col;
                break;
              } else if (perc > PROF_COLS[i].perc && perc < PROF_COLS[i + 1].perc) {
          Severity: Major
          Found in lts/deps/v8/tools/turbolizer/src/disassembly-view.ts - About 45 mins to fix

            Function initializePerfProfile has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              initializePerfProfile(eventCounts) {
    const view = this;
    if (eventCounts !== undefined) {
      view.addrEventCounts = eventCounts;
            Severity: Minor
            Found in lts/deps/v8/tools/turbolizer/src/disassembly-view.ts - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function updateSelection has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              updateSelection(scrollIntoView: boolean = false) {
    super.updateSelection(scrollIntoView);
    const keyPcOffsets = this.sourceResolver.nodesToKeyPcOffsets(this.selection.selectedKeys());
    if (this.offsetSelection) {
      for (const key of this.offsetSelection.selectedKeys()) {
            Severity: Minor
            Found in lts/deps/v8/tools/turbolizer/src/disassembly-view.ts - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            export class DisassemblyView extends TextView {
  SOURCE_POSITION_HEADER_REGEX: any;
  addrEventCounts: any;
  totalEventCounts: any;
  maxEventCounts: any;
            Severity: Major
            Found in lts/deps/v8/tools/turbolizer/src/disassembly-view.ts and 1 other location - About 3 wks to fix
            current/deps/v8/tools/turbolizer/src/disassembly-view.ts on lines 20..394

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 4006.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status