Sign upLogin

enclose-io/compiler

View on GitHub
Star
lts/deps/v8/tools/turbolizer/src/graph-layout.ts

Summary

Maintainability
F
1 mo
Test Coverage

Function newGraphOccupation has a Cognitive Complexity of 149 (exceeds 5 allowed). Consider refactoring.
Open

function newGraphOccupation(graph: Graph) {
  const isSlotFilled = [];
  let maxSlot = 0;
  let minSlot = 0;
  let nodeOccupation: Array<[number, number]> = [];
Severity: Minor
Found in lts/deps/v8/tools/turbolizer/src/graph-layout.ts - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function layoutNodeGraph has a Cognitive Complexity of 59 (exceeds 5 allowed). Consider refactoring.
Open

export function layoutNodeGraph(graph: Graph, showTypes: boolean): void {
  // First determine the set of nodes that have no outputs. Those are the
  // basis for bottom-up DFS to determine rank and node placement.

  const start = performance.now();
Severity: Minor
Found in lts/deps/v8/tools/turbolizer/src/graph-layout.ts - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function newGraphOccupation has 211 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function newGraphOccupation(graph: Graph) {
  const isSlotFilled = [];
  let maxSlot = 0;
  let minSlot = 0;
  let nodeOccupation: Array<[number, number]> = [];
Severity: Major
Found in lts/deps/v8/tools/turbolizer/src/graph-layout.ts - About 1 day to fix

    Function layoutNodeGraph has 188 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function layoutNodeGraph(graph: Graph, showTypes: boolean): void {
  // First determine the set of nodes that have no outputs. Those are the
  // basis for bottom-up DFS to determine rank and node placement.

  const start = performance.now();
    Severity: Major
    Found in lts/deps/v8/tools/turbolizer/src/graph-layout.ts - About 7 hrs to fix

      File graph-layout.ts has 409 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      // Copyright 2015 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import { MAX_RANK_SENTINEL } from "../src/constants";
      Severity: Minor
      Found in lts/deps/v8/tools/turbolizer/src/graph-layout.ts - About 5 hrs to fix

        Function occupyNode has 54 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            occupyNode: function (node: GNode) {
      const getPlacementHint = function (n: GNode) {
        let pos = 0;
        let direction = -1;
        let outputEdges = 0;
        Severity: Major
        Found in lts/deps/v8/tools/turbolizer/src/graph-layout.ts - About 2 hrs to fix

          Function findSpace has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            function findSpace(pos: number, width: number, direction: number) {
    const widthSlots = Math.floor((width + NODE_INPUT_WIDTH - 1) /
      NODE_INPUT_WIDTH);
    const currentSlot = positionToSlot(pos + width / 2);
    let currentScanSlot = currentSlot;
          Severity: Minor
          Found in lts/deps/v8/tools/turbolizer/src/graph-layout.ts - About 1 hr to fix

            Function getPlacementHint has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  const getPlacementHint = function (n: GNode) {
        let pos = 0;
        let direction = -1;
        let outputEdges = 0;
        let inputEdges = 0;
            Severity: Minor
            Found in lts/deps/v8/tools/turbolizer/src/graph-layout.ts - About 1 hr to fix

              Avoid deeply nested control flow statements.
              Open

                              if (output.inputs[l].source == n) {
                  pos += output.x + output.getInputX(l) + NODE_INPUT_WIDTH / 2;
                  outputEdges++;
                  if (l >= (output.inputs.length / 2)) {
                    direction = 1;
              Severity: Major
              Found in lts/deps/v8/tools/turbolizer/src/graph-layout.ts - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                if (inputEdge.isVisible()) {
                  ++inputEdges;
                }
                Severity: Major
                Found in lts/deps/v8/tools/turbolizer/src/graph-layout.ts - About 45 mins to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                  export function layoutNodeGraph(graph: Graph, showTypes: boolean): void {
  // First determine the set of nodes that have no outputs. Those are the
  // basis for bottom-up DFS to determine rank and node placement.

  const start = performance.now();
                  Severity: Major
                  Found in lts/deps/v8/tools/turbolizer/src/graph-layout.ts and 1 other location - About 1 wk to fix
                  current/deps/v8/tools/turbolizer/src/graph-layout.ts on lines 239..461

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 2135.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                  function newGraphOccupation(graph: Graph) {
  const isSlotFilled = [];
  let maxSlot = 0;
  let minSlot = 0;
  let nodeOccupation: Array<[number, number]> = [];
                  Severity: Major
                  Found in lts/deps/v8/tools/turbolizer/src/graph-layout.ts and 1 other location - About 1 wk to fix
                  current/deps/v8/tools/turbolizer/src/graph-layout.ts on lines 13..237

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 2046.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status