Sign upLogin

enclose-io/compiler

View on GitHub
Star
lts/tools/inspector_protocol/jinja2/meta.py

Summary

Maintainability
F
4 days
Test Coverage

Function find_referenced_templates has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

def find_referenced_templates(ast):
    """Finds all the referenced templates from the AST.  This will return an
    iterator over all the hardcoded template extensions, inclusions and
    imports.  If dynamic inheritance or inclusion is used, `None` will be
    yielded.
Severity: Minor
Found in lts/tools/inspector_protocol/jinja2/meta.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if isinstance(template_name, nodes.Const):
                        if isinstance(template_name.value, string_types):
                            yield template_name.value
                    # something dynamic in there
                    else:
Severity: Major
Found in lts/tools/inspector_protocol/jinja2/meta.py - About 45 mins to fix

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

    Severity: Major
    Found in lts/tools/inspector_protocol/jinja2/meta.py and 3 other locations - About 3 days to fix
    current/deps/v8/third_party/jinja2/meta.py on lines 0..106
    current/tools/inspector_protocol/jinja2/meta.py on lines 0..106
    lts/deps/v8/third_party/jinja2/meta.py on lines 0..106

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 356.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status