Sign upLogin

encryptorcode/iam-oauth

View on GitHub
Star
example/src/main/java/com/example/simpleServer/config/GoogleAuthenticationProvider.java

Summary

Maintainability
A
0 mins
Test Coverage

Define a constant instead of duplicating this literal "access_token" 3 times.
Open

        if (object.has("access_token") && object.has("expires_in")) {
Severity: Critical
Found in example/src/main/java/com/example/simpleServer/config/GoogleAuthenticationProvider.java by sonar-java

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

Compliant Solution

private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "expires_in" 3 times.
Open

        if (object.has("access_token") && object.has("expires_in")) {
Severity: Critical
Found in example/src/main/java/com/example/simpleServer/config/GoogleAuthenticationProvider.java by sonar-java

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

Compliant Solution

private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Extra separation in import group before 'java.time.ZonedDateTime'
Open

import java.time.ZonedDateTime;
Severity: Minor
Found in example/src/main/java/com/example/simpleServer/config/GoogleAuthenticationProvider.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Package name 'com.example.simpleServer.config' must match pattern '^[a-z]+(.[a-z][a-z0-9]*)*$'.
Open

package com.example.simpleServer.config;
Severity: Minor
Found in example/src/main/java/com/example/simpleServer/config/GoogleAuthenticationProvider.java by checkstyle

Checks that package names conform to a specified pattern.

The default value of format for module PackageName has beenchosen to match the requirements in the JavaLanguage specification and the Sun coding conventions. Howeverboth underscores and uppercase letters are rather uncommon, so mostconfigurations should probably assign value ^[a-z]+(\.[a-z][a-z0-9]*)*$ toformat for module PackageName.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Each variable declaration must be in its own statement.
Open

        String oauthId = null,
Severity: Minor
Found in example/src/main/java/com/example/simpleServer/config/GoogleAuthenticationProvider.java by checkstyle

Checks that each variable declaration is in its own statement and onits own line.

Rationale: the Java code conventions chapter 6.1 recommends thatdeclarations should be one per line/statement.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'java.time.ZonedDateTime' import. Should be before 'org.json.JSONObject'.
Open

import java.time.ZonedDateTime;
Severity: Minor
Found in example/src/main/java/com/example/simpleServer/config/GoogleAuthenticationProvider.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

There are no issues that match your filters.

Category
Status