Sign upLogin

encryptorcode/iam-oauth

View on GitHub
Star

Showing 399 of 407 total issues

Wrong lexicographical order for 'javax.servlet.http.HttpServletRequest' import. Should be before 'org.springframework.web.servlet.handler.HandlerInterceptorAdapter'.
Open

import javax.servlet.http.HttpServletRequest;
Severity: Minor
Found in src/main/java/io/github/encryptorcode/implementation/spring/AuthenticationInterceptor.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Line is longer than 100 characters (found 104).
Open

    public boolean preHandle(HttpServletRequest request, HttpServletResponse response, Object handler) {
Severity: Minor
Found in src/main/java/io/github/encryptorcode/implementation/spring/AuthenticationInterceptor.java by checkstyle

Checks for long lines.

Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'java.util.logging.Logger' import. Should be before 'javax.crypto.spec.SecretKeySpec'.
Open

import java.util.logging.Logger;
Severity: Minor
Found in src/main/java/io/github/encryptorcode/implementation/security/BaseSecurityHandler.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Each variable declaration must be in its own statement.
Open

        String oauthId = null,
Severity: Minor
Found in example/src/main/java/com/example/simpleServer/config/GoogleAuthenticationProvider.java by checkstyle

Checks that each variable declaration is in its own statement and onits own line.

Rationale: the Java code conventions chapter 6.1 recommends thatdeclarations should be one per line/statement.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Package name 'com.example.simpleServer.config' must match pattern '^[a-z]+(.[a-z][a-z0-9]*)*$'.
Open

package com.example.simpleServer.config;
Severity: Minor
Found in example/src/main/java/com/example/simpleServer/config/SpringDispatcher.java by checkstyle

Checks that package names conform to a specified pattern.

The default value of format for module PackageName has beenchosen to match the requirements in the JavaLanguage specification and the Sun coding conventions. Howeverboth underscores and uppercase letters are rather uncommon, so mostconfigurations should probably assign value ^[a-z]+(\.[a-z][a-z0-9]*)*$ toformat for module PackageName.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Line is longer than 100 characters (found 146).
Open

 * In case you plan on using a single provider, You can set the default login url to /login/{provider} in your {@link AuthenticationConfiguration}
Severity: Minor
Found in src/main/java/io/github/encryptorcode/implementation/spring/AuthenticationController.java by checkstyle

Checks for long lines.

Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Line is longer than 100 characters (found 108).
Open

    private static final AuthenticationService AUTHENTICATION_SERVICE = AuthenticationService.getInstance();
Severity: Minor
Found in src/main/java/io/github/encryptorcode/implementation/spring/AuthenticationController.java by checkstyle

Checks for long lines.

Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Empty catch block.
Open

        } catch (IOException ignored) {
Severity: Minor
Found in src/main/java/io/github/encryptorcode/implementation/oauth/AOauthProviderImpl.java by checkstyle

Checks for empty catch blocks.By default check allows empty catch block with any comment inside.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'java.security.InvalidAlgorithmParameterException' import. Should be before 'javax.crypto.spec.SecretKeySpec'.
Open

import java.security.InvalidAlgorithmParameterException;
Severity: Minor
Found in src/main/java/io/github/encryptorcode/implementation/security/BaseSecurityHandler.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Line is longer than 100 characters (found 180).
Open

        } catch (NoSuchPaddingException | NoSuchAlgorithmException | InvalidKeyException | IllegalBlockSizeException | BadPaddingException | InvalidAlgorithmParameterException e) {
Severity: Minor
Found in src/main/java/io/github/encryptorcode/implementation/security/BaseSecurityHandler.java by checkstyle

Checks for long lines.

Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Line is longer than 100 characters (found 123).
Open

    private static final AuthenticationService<Session, User> AUTHENTICATION_SERVICE = AuthenticationService.getInstance();
Severity: Minor
Found in example/src/main/java/com/example/simpleServer/controllers/MainController.java by checkstyle

Checks for long lines.

Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'javax.servlet.http.HttpServletRequest' import. Should be before 'org.springframework.web.servlet.ModelAndView'.
Open

import javax.servlet.http.HttpServletRequest;
Severity: Minor
Found in src/main/java/io/github/encryptorcode/implementation/spring/AuthenticationController.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'io.github.encryptorcode.entity.OauthToken' import. Should be before 'io.github.encryptorcode.service.OauthProvider'.
Open

import io.github.encryptorcode.entity.OauthToken;
Severity: Minor
Found in src/main/java/io/github/encryptorcode/implementation/oauth/AOauthProviderImpl.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'java.util.Random'
Open

import java.util.Random;
Severity: Minor
Found in src/main/java/io/github/encryptorcode/implementation/security/ZeroSecurityHandler.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Package name 'com.example.simpleServer.controllers' must match pattern '^[a-z]+(.[a-z][a-z0-9]*)*$'.
Open

package com.example.simpleServer.controllers;
Severity: Minor
Found in example/src/main/java/com/example/simpleServer/controllers/MainController.java by checkstyle

Checks that package names conform to a specified pattern.

The default value of format for module PackageName has beenchosen to match the requirements in the JavaLanguage specification and the Sun coding conventions. Howeverboth underscores and uppercase letters are rather uncommon, so mostconfigurations should probably assign value ^[a-z]+(\.[a-z][a-z0-9]*)*$ toformat for module PackageName.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

'+' should be on a new line.
Open

                "<ul>" + NEW_LINE +
Severity: Minor
Found in example/src/main/java/com/example/simpleServer/controllers/MainController.java by checkstyle

Checks the policy on how to wrap lines on operators.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'java.time.ZonedDateTime'
Open

import java.time.ZonedDateTime;
Severity: Minor
Found in example/src/main/java/com/example/simpleServer/config/GoogleAuthenticationProvider.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Line is longer than 100 characters (found 103).
Open

 * A simple controller implementation using spring annotations for handling all the authentication urls
Severity: Minor
Found in src/main/java/io/github/encryptorcode/implementation/spring/AuthenticationController.java by checkstyle

Checks for long lines.

Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

'+' should be on a new line.
Open

                "?client_id=" + this.clientId +
Severity: Minor
Found in src/main/java/io/github/encryptorcode/implementation/oauth/AOauthProviderImpl.java by checkstyle

Checks the policy on how to wrap lines on operators.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Using the '.*' form of import should be avoided - javax.crypto.*.
Open

import javax.crypto.*;
Severity: Minor
Found in src/main/java/io/github/encryptorcode/implementation/security/BaseSecurityHandler.java by checkstyle

Checks that there are no import statements that use the * notation.

Rationale: Importing all classes from a package or staticmembers from a class leads to tight coupling between packagesor classes and might lead to problems when a new version of alibrary introduces name clashes.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Severity
Category
Status
Source
Language