encryptorcode/iam-oauth

View on GitHub
src/main/java/io/github/encryptorcode/implementation/storage/jdbc/mappers/AuthenticationDetailsMapper.java

Summary

Maintainability
A
0 mins
Test Coverage

Rename this variable to not match a restricted identifier.
Open

    public AuthenticationDetail map(Record record) {

Even if it is technically possible, Restricted Identifiers should not be used as identifiers. This is only possible for compatibility reasons, using it in Java code is confusing and should be avoided.

Note that this applies to any version of Java, including the one where these identifiers are not yet restricted, to avoid future confusion.

This rule reports an issue when restricted identifiers:

  • var
  • yield
  • record

are used as identifiers.

Noncompliant Code Example

var var = "var"; // Noncompliant: compiles but this code is confusing
var = "what is this?";

int yield(int i) { // Noncompliant
  return switch (i) {
    case 1: yield(0); // This is a yield from switch expression, not a recursive call.
    default: yield(i-1);
  };
}

String record = "record"; // Noncompliant

Compliant Solution

var myVariable = "var";

int minusOne(int i) {
  return switch (i) {
    case 1: yield(0);
    default: yield(i-1);
  };
}

String myRecord = "record";

See

First sentence of Javadoc is missing an ending period.
Open

/**

Checks thatJavadoc summary sentence does not contain phrases that are not recommended to use.Summaries that contain only the {@inheritDoc} tag are skipped. Check alsoviolate Javadoc that does not contain first sentence.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'io.github.encryptorcode.implementation.storage.jdbc.tables.AUTHENTICATION_DETAILS.AUTHENTICATION_DETAILS'
Open

import static io.github.encryptorcode.implementation.storage.jdbc.tables.AUTHENTICATION_DETAILS.AUTHENTICATION_DETAILS;

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'io.github.encryptorcode.implementation.storage.jdbc.tables.AUTHENTICATION_DETAILS.AUTHENTICATION_DETAILS' import. Should be before 'org.jooq.RecordMapper'.
Open

import static io.github.encryptorcode.implementation.storage.jdbc.tables.AUTHENTICATION_DETAILS.AUTHENTICATION_DETAILS;

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Line is longer than 100 characters (found 117).
Open

 * A mapper implementation that helps JOOQ to convert {@link Record} to a proper POJO of {@link AuthenticationDetail}

Checks for long lines.

Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

There are no issues that match your filters.

Category
Status