Sign upLogin

enderahmetyurt/turkish_support

View on GitHub
Star

Showing 9 of 9 total issues

Method <=> has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    def <=>(other_string)
      return nil unless other_string.is_a? String

      each_char.with_index do |ch, i|
        position1 = ASCII_ALPHABET[ch]
Severity: Minor
Found in lib/turkish_support/string_methods.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method titleize has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def titleize(conjuctions = true) # rubocop:disable Metrics/AbcSize
      split.map do |word|
        word.downcase!
        if conjuction?(word) && !conjuctions
          word
Severity: Minor
Found in lib/turkish_support/string_methods.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sort has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def sort
      if block_given?
        super
      else
        sort_by do |item|
Severity: Minor
Found in lib/turkish_support/array_methods.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method swapcase has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def swapcase
      extend(TurkishSupportHelpers)
      chars.map do |ch|
        if tr_char?(ch)
          tr_lower?(ch) ? ch.upcase : ch.downcase
Severity: Minor
Found in lib/turkish_support/string_methods.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

      return  1
Severity: Major
Found in lib/turkish_support/string_methods.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

          return -1 if length < other_string.length
    Severity: Major
    Found in lib/turkish_support/string_methods.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return  0 if length == other_string.length
      Severity: Major
      Found in lib/turkish_support/string_methods.rb - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def upper(first = nil, last = nil)
    return ALPHA[:upper] if first.nil? || last.nil?
    ALPHA[:upper][ALPHA[:upper].index(first)..ALPHA[:upper].index(last)]
        Severity: Minor
        Found in lib/turkish_support/helpers.rb and 1 other location - About 25 mins to fix
        lib/turkish_support/helpers.rb on lines 92..94

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 31.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def lower(first = nil, last = nil)
    return ALPHA[:lower] if first.nil? || last.nil?
    ALPHA[:lower][ALPHA[:lower].index(first)..ALPHA[:lower].index(last)]
        Severity: Minor
        Found in lib/turkish_support/helpers.rb and 1 other location - About 25 mins to fix
        lib/turkish_support/helpers.rb on lines 101..103

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 31.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language