engine-bay/admin-portal

View on GitHub
EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx

Summary

Maintainability
D
2 days
Test Coverage

Function updatedTreeData has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        (blueprint: Blueprint) => {
          const expressionBlueprintChildren =
            blueprint.expressionBlueprints.map((expressionBlueprint) => {
              return {
                nodeId: expressionBlueprint.id,
Severity: Major
Found in EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx - About 2 hrs to fix

    Function WorkbookTree has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    export const WorkbookTree = ({
      //   selectedElement,
      onBlueprintSelected,
      onElementSelected,
    }: {
    Severity: Minor
    Found in EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            for (const dataTableBlueprint of blueprint.dataTableBlueprints) {
              blueprintIdDictionary[dataTableBlueprint.id] = blueprint.id;
              elementIdDictionary[dataTableBlueprint.id] = dataTableBlueprint.id;
              elementTypeDictionary[dataTableBlueprint.id] = ElementType.DataTable;
            }
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 140..145
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 151..157
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 158..162

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            for (const expressionBlueprint of blueprint.expressionBlueprints) {
              blueprintIdDictionary[expressionBlueprint.id] = blueprint.id;
              elementIdDictionary[expressionBlueprint.id] = expressionBlueprint.id;
              elementTypeDictionary[expressionBlueprint.id] =
                ElementType.Expression;
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 146..150
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 151..157
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 158..162

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            for (const triggerBlueprint of blueprint.triggerBlueprints) {
              blueprintIdDictionary[triggerBlueprint.id] = blueprint.id;
              elementIdDictionary[triggerBlueprint.id] = triggerBlueprint.id;
              elementTypeDictionary[triggerBlueprint.id] = ElementType.Trigger;
            }
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 140..145
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 146..150
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 151..157

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            for (const dataVariableBlueprint of blueprint.dataVariableBlueprints) {
              blueprintIdDictionary[dataVariableBlueprint.id] = blueprint.id;
              elementIdDictionary[dataVariableBlueprint.id] =
                dataVariableBlueprint.id;
              elementTypeDictionary[dataVariableBlueprint.id] =
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 140..145
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 146..150
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 158..162

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

              if (expressionBlueprintChildren.length > 0) {
                children.push({
                  nodeId: `${blueprint.id}-expression-blueprints`,
                  label: `Expressions`,
                  children: expressionBlueprintChildren,
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 71..77
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 79..85
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 95..101

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

              if (dataVariableBlueprintChildren.length > 0) {
                children.push({
                  nodeId: `${blueprint.id}-data-variable-blueprints`,
                  label: `Data Variables`,
                  children: dataVariableBlueprintChildren,
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 79..85
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 87..93
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 95..101

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

              if (triggerBlueprintChildren.length > 0) {
                children.push({
                  nodeId: `${blueprint.id}-trigger-blueprints`,
                  label: `Triggers`,
                  children: triggerBlueprintChildren,
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 71..77
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 79..85
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 87..93

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

              if (dataTableBlueprintChildren.length > 0) {
                children.push({
                  nodeId: `${blueprint.id}-data-table-blueprints`,
                  label: `Data Tables`,
                  children: dataTableBlueprintChildren,
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 71..77
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 87..93
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 95..101

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

              const expressionBlueprintChildren =
                blueprint.expressionBlueprints.map((expressionBlueprint) => {
                  return {
                    nodeId: expressionBlueprint.id,
                    label: expressionBlueprint.expression,
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 43..49
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 51..58
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 60..67

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

              const dataVariableBlueprintChildren =
                blueprint.dataVariableBlueprints.map((dataVariableBlueprint) => {
                  return {
                    nodeId: dataVariableBlueprint.id,
                    label: dataVariableBlueprint.name,
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 35..41
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 51..58
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 60..67

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

              const triggerBlueprintChildren = blueprint.triggerBlueprints.map(
                (triggerBlueprint) => {
                  return {
                    nodeId: triggerBlueprint.id,
                    label: triggerBlueprint.name,
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 35..41
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 43..49
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 51..58

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

              const dataTableBlueprintChildren = blueprint.dataTableBlueprints.map(
                (dataTableBlueprint) => {
                  return {
                    nodeId: dataTableBlueprint.id,
                    label: dataTableBlueprint.name,
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 35..41
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 43..49
    EngineBay.AdminPortal/AdminPortal/src/pages/studio/WorkbookTree.tsx on lines 60..67

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status