Sign upLogin

engineyard/engineyard

View on GitHub
Star
lib/engineyard/serverside_runner.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method run has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def run(remote_command, out, err)
      cmd = Escape.shell_command(['bash', '-lc', remote_command])

      if cmd.respond_to?(:encoding) && cmd.respond_to?(:force_encoding)
        out << "Encoding: #{cmd.encoding.name}" if @verbose
Severity: Minor
Found in lib/engineyard/serverside_runner.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ssh has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def ssh(cmd, hostname, username, out, err)
      exit_code = 1
      Net::SSH.start(hostname, username, net_ssh_options) do |net_ssh|
        net_ssh.open_channel do |channel|
          channel.exec cmd do |_, success|
Severity: Minor
Found in lib/engineyard/serverside_runner.rb - About 1 hr to fix

    Method ssh has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def ssh(cmd, hostname, username, out, err)
    Severity: Minor
    Found in lib/engineyard/serverside_runner.rb - About 35 mins to fix

      Method load_adapter has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def load_adapter(bridge, app, environment, verbose, serverside_version)
      Severity: Minor
      Found in lib/engineyard/serverside_runner.rb - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status