engineyard/todo

View on GitHub

Showing 145 of 145 total issues

Function dirCheck has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

function dirCheck( dir, cur, doneName, checkSet, nodeCheck, isXML ) {
Severity: Minor
Found in public/javascripts/jquery.js - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if ( name.indexOf( "data-" ) === 0 ) {
                                name = jQuery.camelCase( name.substring(5) );
    
                                dataAttr( this[0], name, data[ name ] );
                            }
    Severity: Major
    Found in public/javascripts/jquery.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if ( elem && elem.parentNode ) {
                                  // Handle the case where IE and Opera return items
                                  // by name instead of ID
                                  if ( elem.id === match[3] ) {
                                      return makeArray( [ elem ], extra );
      Severity: Major
      Found in public/javascripts/jquery.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if ( ret[r] === ret[n] ) {
                                    ret.splice(n--, 1);
                                    break;
                                }
        Severity: Major
        Found in public/javascripts/jquery.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                              if ( xml && xml.documentElement /* #4958 */ ) {
                                                  responses.xml = xml;
                                              }
          Severity: Major
          Found in public/javascripts/jquery.js - About 45 mins to fix

            Function inspectPrefiltersOrTransports has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function inspectPrefiltersOrTransports( structure, options, originalOptions, jqXHR,
                    dataType /* internal */, inspected /* internal */ ) {
            Severity: Minor
            Found in public/javascripts/jquery.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      if ( match.jquery ? match.index( cur ) > -1 : jQuery( cur ).is( match ) ) {
                                          ret.push({ selector: selector, elem: cur, level: level });
                                      }
              Severity: Major
              Found in public/javascripts/jquery.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                    if ( tmp[ 0 ] === prev || tmp[ 0 ] === "*" ) {
                                        conv2 = converters[ tmp[1] + " " + current ];
                                        if ( conv2 ) {
                                            conv1 = converters[ conv1 ];
                                            if ( conv1 === true ) {
                Severity: Major
                Found in public/javascripts/jquery.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                                      if ( xhrOnUnloadAbort ) {
                                                          delete xhrCallbacks[ handle ];
                                                      }
                  Severity: Major
                  Found in public/javascripts/jquery.js - About 45 mins to fix

                    Consider simplifying this complex logical expression.
                    Open

                            if ( !seed && parts.length > 1 && context.nodeType === 9 && !contextXML &&
                                    Expr.match.ID.test(parts[0]) && !Expr.match.ID.test(parts[parts.length - 1]) ) {
                    
                                ret = Sizzle.find( parts.shift(), context, contextXML );
                                context = ret.expr ?
                    Severity: Major
                    Found in public/javascripts/jquery.js - About 40 mins to fix

                      Consider simplifying this complex logical expression.
                      Open

                      if ( jQuery.expr && jQuery.expr.filters ) {
                          jQuery.expr.filters.hidden = function( elem ) {
                              var width = elem.offsetWidth,
                                  height = elem.offsetHeight;
                      
                      
                      Severity: Major
                      Found in public/javascripts/jquery.js - About 40 mins to fix

                        Consider simplifying this complex logical expression.
                        Open

                        if ( !jQuery.support.opacity ) {
                            jQuery.cssHooks.opacity = {
                                get: function( elem, computed ) {
                                    // IE uses filters for opacity
                                    return ropacity.test( (computed && elem.currentStyle ? elem.currentStyle.filter : elem.style.filter) || "" ) ?
                        Severity: Major
                        Found in public/javascripts/jquery.js - About 40 mins to fix

                          Consider simplifying this complex logical expression.
                          Open

                                          if ( (e.keyCode === 13 && !jQuery.nodeName( elem, "textarea" ) ) ||
                                              (e.keyCode === 32 && (type === "checkbox" || type === "radio")) ||
                                              type === "select-multiple" ) {
                                              testChange.call( this, e );
                                          }
                          Severity: Major
                          Found in public/javascripts/jquery.js - About 40 mins to fix

                            Consider simplifying this complex logical expression.
                            Open

                                    if ( (!id || (pvt && id && !cache[ id ][ internalKey ])) && getByName && data === undefined ) {
                                        return;
                                    }
                            Severity: Major
                            Found in public/javascripts/jquery.js - About 40 mins to fix

                              Consider simplifying this complex logical expression.
                              Open

                                  if ( event.liveFired === this || !events || !events.live || event.target.disabled || event.button && event.type === "click" ) {
                                      return;
                                  }
                              Severity: Major
                              Found in public/javascripts/jquery.js - About 40 mins to fix

                                Consider simplifying this complex logical expression.
                                Open

                                        } else if ( typeof value === "string" && !rnocache.test( value ) &&
                                            (jQuery.support.leadingWhitespace || !rleadingWhitespace.test( value )) &&
                                            !wrapMap[ (rtagName.exec( value ) || ["", ""])[1].toLowerCase() ] ) {
                                
                                            value = value.replace(rxhtmlTag, "<$1></$2>");
                                Severity: Major
                                Found in public/javascripts/jquery.js - About 40 mins to fix

                                  Consider simplifying this complex logical expression.
                                  Open

                                          if ( s.crossDomain == null ) {
                                              parts = rurl.exec( s.url.toLowerCase() );
                                              s.crossDomain = !!( parts &&
                                                  ( parts[ 1 ] != ajaxLocParts[ 1 ] || parts[ 2 ] != ajaxLocParts[ 2 ] ||
                                                      ( parts[ 3 ] || ( parts[ 1 ] === "http:" ? 80 : 443 ) ) !=
                                  Severity: Major
                                  Found in public/javascripts/jquery.js - About 40 mins to fix

                                    Function PSEUDO has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                            PSEUDO: function( match, curLoop, inplace, result, not ) {
                                    Severity: Minor
                                    Found in public/javascripts/jquery.js - About 35 mins to fix

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                                  for ( ; i < length; i++ ) {
                                                      value = callback( elems[ i ], i, arg );
                                      
                                                      if ( value != null ) {
                                                          ret[ ret.length ] = value;
                                      Severity: Minor
                                      Found in public/javascripts/jquery.js and 1 other location - About 35 mins to fix
                                      public/javascripts/jquery.js on lines 758..764

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 47.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                                  for ( key in elems ) {
                                                      value = callback( elems[ key ], key, arg );
                                      
                                                      if ( value != null ) {
                                                          ret[ ret.length ] = value;
                                      Severity: Minor
                                      Found in public/javascripts/jquery.js and 1 other location - About 35 mins to fix
                                      public/javascripts/jquery.js on lines 748..754

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 47.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language