enter-at/node-aws-lambda-handlers

View on GitHub
src/handler/APIGatewayProxyHandler.ts

Summary

Maintainability
A
2 hrs
Test Coverage
B
87%

Function handleError has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static handleError(err: Error): APIGatewayResponse {
        if (err instanceof ForbiddenError) {
            return forbidden(err.details);
        }
        if (err instanceof UnauthorizedError) {
Severity: Minor
Found in src/handler/APIGatewayProxyHandler.ts - About 1 hr to fix

Function handleError has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Wontfix

    private static handleError(err: Error): APIGatewayResponse {
        if (err instanceof ForbiddenError) {
            return forbidden(err.details);
        }
        if (err instanceof UnauthorizedError) {
Severity: Minor
Found in src/handler/APIGatewayProxyHandler.ts - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Invalid

            return notFound(err.details);
Severity: Major
Found in src/handler/APIGatewayProxyHandler.ts - About 30 mins to fix

Avoid too many return statements within this function.
Invalid

        return internalServerError();
Severity: Major
Found in src/handler/APIGatewayProxyHandler.ts - About 30 mins to fix

Avoid too many return statements within this function.
Open

            return unprocessableEntity(err.details);
Severity: Major
Found in src/handler/APIGatewayProxyHandler.ts - About 30 mins to fix

Avoid too many return statements within this function.
Open

            return conflict(err.details);
Severity: Major
Found in src/handler/APIGatewayProxyHandler.ts - About 30 mins to fix

There are no issues that match your filters.

Category
Status