Sign upLogin

epam/miew

View on GitHub
Star
packages/miew/src/chem/Volume.js

Summary

Maintainability
F
3 days
Test Coverage

Function buildTiledTexture has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

  buildTiledTexture() {
    let tilesX = Math.ceil(Math.sqrt((this._dimZ * this._dimY) / this._dimX))

    let width = tilesX * (this._dimX + 2) - 1
    width = pow2ceil(width)
Severity: Minor
Found in packages/miew/src/chem/Volume.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function constructor has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  constructor(type, dimensions, box, vecSize, data, volumeInfo) {
    this._box = box.clone()
    this._dimVec = Math.max(Math.floor(vecSize || 1), 1)
    this._volumeInfo = volumeInfo
Severity: Major
Found in packages/miew/src/chem/Volume.js - About 2 hrs to fix

    Function buildTiledTexture has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      buildTiledTexture() {
    let tilesX = Math.ceil(Math.sqrt((this._dimZ * this._dimY) / this._dimX))

    let width = tilesX * (this._dimX + 2) - 1
    width = pow2ceil(width)
    Severity: Major
    Found in packages/miew/src/chem/Volume.js - About 2 hrs to fix

      Function computeGradient has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        computeGradient() {
    if (this._dimVec !== 1) {
      // gradient can only be computed for scalar fields
      return null
    }
      Severity: Minor
      Found in packages/miew/src/chem/Volume.js - About 1 hr to fix

        Function setValue has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                this.setValue = function (x, y, z, a, b, c) {
        Severity: Minor
        Found in packages/miew/src/chem/Volume.js - About 45 mins to fix

          Function addValue has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  this.addValue = function (x, y, z, a, b, c) {
          Severity: Minor
          Found in packages/miew/src/chem/Volume.js - About 45 mins to fix

            Function setValue has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    this.setValue = function (x, y, z, a, b) {
            Severity: Minor
            Found in packages/miew/src/chem/Volume.js - About 35 mins to fix

              Function addValue has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      this.addValue = function (x, y, z, a, b) {
              Severity: Minor
              Found in packages/miew/src/chem/Volume.js - About 35 mins to fix

                Function computeGradient has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                  computeGradient() {
    if (this._dimVec !== 1) {
      // gradient can only be computed for scalar fields
      return null
    }
                Severity: Minor
                Found in packages/miew/src/chem/Volume.js - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        this.addValue = function (x, y, z, a, b, c) {
          const idx =
            x * this._dimVec + y * this._rowElements + z * this._planeElements
          this._data[idx] += a
          this._data[idx + 1] += b
                Severity: Major
                Found in packages/miew/src/chem/Volume.js and 1 other location - About 3 hrs to fix
                packages/miew/src/chem/Volume.js on lines 94..100

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 114.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        this.setValue = function (x, y, z, a, b, c) {
          const idx =
            x * this._dimVec + y * this._rowElements + z * this._planeElements
          this._data[idx] = a
          this._data[idx + 1] = b
                Severity: Major
                Found in packages/miew/src/chem/Volume.js and 1 other location - About 3 hrs to fix
                packages/miew/src/chem/Volume.js on lines 102..108

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 114.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        this.setValue = function (x, y, z, a, b) {
          const idx =
            x * this._dimVec + y * this._rowElements + z * this._planeElements
          this._data[idx] = a
          this._data[idx + 1] = b
                Severity: Major
                Found in packages/miew/src/chem/Volume.js and 1 other location - About 2 hrs to fix
                packages/miew/src/chem/Volume.js on lines 79..84

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 94.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        this.addValue = function (x, y, z, a, b) {
          const idx =
            x * this._dimVec + y * this._rowElements + z * this._planeElements
          this._data[idx] += a
          this._data[idx + 1] += b
                Severity: Major
                Found in packages/miew/src/chem/Volume.js and 1 other location - About 2 hrs to fix
                packages/miew/src/chem/Volume.js on lines 72..77

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 94.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status