Sign upLogin

epam/miew

View on GitHub
Star
packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js

Summary

Maintainability
D
3 days
Test Coverage

Function createVoxels has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

  createVoxels() {
    let numAtomsRefs
    let rad
    const ATOM_VOXEL_REF_SCALE = 4.5
Severity: Minor
Found in packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createVoxels has 106 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  createVoxels() {
    let numAtomsRefs
    let rad
    const ATOM_VOXEL_REF_SCALE = 4.5
Severity: Major
Found in packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js - About 4 hrs to fix

    File IsosurfaceBuildNormals.js has 273 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import utils from '../../utils'
import { Vector3 } from 'three'

// suppress some JSHint warnings
/* jshint bitwise: false */
    Severity: Minor
    Found in packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js - About 2 hrs to fix

      Function buildNormals has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        buildNormals(numVertices, vertices, normals) {
    const self = this
    let numCloseAtoms = 0
    let vx = 0
    let vy = 0
      Severity: Major
      Found in packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js - About 2 hrs to fix

        Function buildColors has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          buildColors(numVertices, vertices, colors, radiusColorSmoothness) {
    const self = this
    let vx = 0.0
    let vy = 0.0
    let vz = 0.0
        Severity: Minor
        Found in packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js - About 1 hr to fix

          Function buildNormals has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            buildNormals(numVertices, vertices, normals) {
    const self = this
    let numCloseAtoms = 0
    let vx = 0
    let vy = 0
          Severity: Minor
          Found in packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                      if (this._voxelList[indVoxel] < 0) {
              atomsList[numAtomsRefs * 2 + 0] = i
              atomsList[numAtomsRefs * 2 + 1] = 0 - 1
              this._voxelList[indVoxel] = numAtomsRefs
              numAtomsRefs++
          Severity: Major
          Found in packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js - About 45 mins to fix

            Function buildColors has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              buildColors(numVertices, vertices, colors, radiusColorSmoothness) {
    const self = this
    let vx = 0.0
    let vy = 0.0
    let vz = 0.0
            Severity: Minor
            Found in packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                  let yIndMax = Math.floor(
        (atoms[i].coord.y - this._vBoxMin.y + rad) * numCells * yScale
      )
            Severity: Major
            Found in packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js and 5 other locations - About 50 mins to fix
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 109..111
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 112..114
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 115..117
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 118..120
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 124..126

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                  let zIndMax = Math.floor(
        (atoms[i].coord.z - this._vBoxMin.z + rad) * numCells * zScale
      )
            Severity: Major
            Found in packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js and 5 other locations - About 50 mins to fix
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 109..111
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 112..114
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 115..117
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 118..120
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 121..123

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                  let yIndMin = Math.floor(
        (atoms[i].coord.y - this._vBoxMin.y - rad) * numCells * yScale
      )
            Severity: Major
            Found in packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js and 5 other locations - About 50 mins to fix
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 109..111
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 115..117
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 118..120
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 121..123
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 124..126

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                  let xIndMin = Math.floor(
        (atoms[i].coord.x - this._vBoxMin.x - rad) * numCells * xScale
      )
            Severity: Major
            Found in packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js and 5 other locations - About 50 mins to fix
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 112..114
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 115..117
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 118..120
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 121..123
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 124..126

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                  let zIndMin = Math.floor(
        (atoms[i].coord.z - this._vBoxMin.z - rad) * numCells * zScale
      )
            Severity: Major
            Found in packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js and 5 other locations - About 50 mins to fix
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 109..111
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 112..114
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 118..120
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 121..123
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 124..126

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                  let xIndMax = Math.floor(
        (atoms[i].coord.x - this._vBoxMin.x + rad) * numCells * xScale
      )
            Severity: Major
            Found in packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js and 5 other locations - About 50 mins to fix
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 109..111
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 112..114
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 115..117
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 121..123
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 124..126

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                const yInd = Math.floor(
      (point.y - this._vBoxMin.y) * this._numCells * this._yScale
    )
            Severity: Minor
            Found in packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js and 1 other location - About 35 mins to fix
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 194..196

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                const zInd = Math.floor(
      (point.z - this._vBoxMin.z) * this._numCells * this._zScale
    )
            Severity: Minor
            Found in packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js and 1 other location - About 35 mins to fix
            packages/miew/src/gfx/geometries/IsosurfaceBuildNormals.js on lines 191..193

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status