Sign upLogin

epam/miew

View on GitHub
Star
packages/miew/src/options.js

Summary

Maintainability
D
2 days
Test Coverage

File options.js has 406 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import settings from './settings'
import utils from './utils'
import logger from './utils/logger'
import { isString, set, get, isArray, isEmpty } from 'lodash'
Severity: Minor
Found in packages/miew/src/options.js - About 5 hrs to fix

    Function _fromArray has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

    function _fromArray(entries) {
  repIndex = 0
  const opts = {}
  for (let i = 0, n = entries.length; i < n; ++i) {
    const /** string[] */ entry = entries[i]
    Severity: Minor
    Found in packages/miew/src/options.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function toURL has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function toURL(opts) {
  const stringList = []
  let idx = 0

  function checkAndAdd(prefix, value) {
    Severity: Major
    Found in packages/miew/src/options.js - About 2 hrs to fix

      Function toURL has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

      function toURL(opts) {
  const stringList = []
  let idx = 0

  function checkAndAdd(prefix, value) {
      Severity: Minor
      Found in packages/miew/src/options.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function toScript has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

      function toScript(opts) {
  const commandsList = []
  let idx = 0
  function checkAndAdd(command, value, saveQuotes) {
    if (value !== null && value !== undefined) {
      Severity: Minor
      Found in packages/miew/src/options.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function extractArgs has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

      function extractArgs(input, defaultsDict, params) {
  if (input) {
    const bang = input.indexOf(cOptsSep)
    const inputVal = parseParams(
      input.substr(0, bang >= 0 ? bang : undefined),
      Severity: Minor
      Found in packages/miew/src/options.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function toScript has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function toScript(opts) {
  const commandsList = []
  let idx = 0
  function checkAndAdd(command, value, saveQuotes) {
    if (value !== null && value !== undefined) {
      Severity: Minor
      Found in packages/miew/src/options.js - About 1 hr to fix

        Function extractArgs has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function extractArgs(input, defaultsDict, params) {
  if (input) {
    const bang = input.indexOf(cOptsSep)
    const inputVal = parseParams(
      input.substr(0, bang >= 0 ? bang : undefined),
        Severity: Minor
        Found in packages/miew/src/options.js - About 1 hr to fix

          Function rep has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            rep(value, opts) {
    ensureRepList(opts)
    repIndex = Number(value)
    // clamp the index to one greater than the last
    repIndex =
          Severity: Minor
          Found in packages/miew/src/options.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            function addObjects(objList) {
    if (!objList) {
      return
    }
    for (let i = 0, n = objList.length; i < n; ++i) {
          Severity: Major
          Found in packages/miew/src/options.js and 1 other location - About 1 hr to fix
          packages/miew/src/options.js on lines 456..463

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            function addObjects(objList) {
    if (!objList) {
      return
    }
    for (let i = 0, n = objList.length; i < n; ++i) {
          Severity: Major
          Found in packages/miew/src/options.js and 1 other location - About 1 hr to fix
          packages/miew/src/options.js on lines 346..353

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status