eparreno/rack-jwt

View on GitHub

Showing 5 of 5 total issues

Method decode has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

      def self.decode(token, secret, verify, options = {})
        raise 'Invalid token format.'     unless valid_token_format?(token)
        raise 'Invalid secret type.'      unless secret_of_valid_type?(secret)
        raise 'Unsupported verify value.' unless verify_of_valid_type?(verify)
        options[:algorithm] = 'HS256'     if options[:algorithm].nil?
Severity: Minor
Found in lib/rack/jwt/token.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method verify_token has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def verify_token(env)
        token_extractor = TokenExtractor.for(env, @token_location)
        token_extractor.validate!

        decoded_token = Token.decode(token_extractor.token, @secret, @verify, @options)
Severity: Minor
Found in lib/rack/jwt/auth.rb - About 1 hr to fix

    Method check_exclude_type! has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def check_exclude_type!
            unless @exclude.is_a?(Array)
              raise ArgumentError, 'exclude argument must be an Array'
            end
    
    
    Severity: Minor
    Found in lib/rack/jwt/auth.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method encode has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def self.encode(payload, secret, alg = 'HS256', headers = {})
            raise 'Invalid payload. Must be a Hash.' unless payload.is_a?(Hash)
            raise 'Invalid secret type.'             unless secret_of_valid_type?(secret)
            raise 'Unsupported algorithm'            unless algorithm_supported?(alg)
    
    
    Severity: Minor
    Found in lib/rack/jwt/token.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check_secret! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def check_secret!
            if @secret.nil? || (@secret.is_a?(String) && @secret.empty?)
              if @options[:algorithm] != 'none' && @options[:jwks].nil?
                raise ArgumentError, 'secret argument can only be nil/empty for the "none" algorithm'
              end
    Severity: Minor
    Found in lib/rack/jwt/auth.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language