Sign upLogin

epegzz/node-scraper

View on GitHub
Star

Showing 2 of 2 total issues

Function scrape has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function* scrape(requestUrlOrArgs, parserFunction, context) {
  // Allow passing either request url or request args
  const requestArgs = {
    ...(typeof requestUrlOrArgs === 'string'
      ? { url: requestUrlOrArgs }
Severity: Major
Found in src/node-scraper.js - About 2 hrs to fix

    Function scrape has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    async function* scrape(requestUrlOrArgs, parserFunction, context) {
  // Allow passing either request url or request args
  const requestArgs = {
    ...(typeof requestUrlOrArgs === 'string'
      ? { url: requestUrlOrArgs }
    Severity: Minor
    Found in src/node-scraper.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language