Sign upLogin

ephread/Instructions

View on GitHub
Star
Sources/Instructions/Managers/Internal/CoachMarkDisplayManager.swift

Summary

Maintainability
C
1 day
Test Coverage
D
68%

Function showNew has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    func showNew(coachMarkView: CoachMarkView, from coachMark: CoachMark,
                 at index: Int, animated: Bool = true, completion: (() -> Void)? = nil) {
        guard let overlay = overlayManager else { return }

        prepare(coachMarkView: coachMarkView, forDisplayIn: overlay.overlayView.superview!,
Severity: Minor
Found in Sources/Instructions/Managers/Internal/CoachMarkDisplayManager.swift - About 1 hr to fix

    Function hide has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        func hide(coachMarkView: UIView, from coachMark: CoachMark, at index: Int,
              animated: Bool, beforeTransition: Bool, completion: (() -> Void)? = nil) {
        guard let overlay = overlayManager else { return }

        guard animated else {
    Severity: Minor
    Found in Sources/Instructions/Managers/Internal/CoachMarkDisplayManager.swift - About 1 hr to fix

      Function hide has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          func hide(coachMarkView: UIView, from coachMark: CoachMark, at index: Int,
              animated: Bool, beforeTransition: Bool, completion: (() -> Void)? = nil) {
      Severity: Minor
      Found in Sources/Instructions/Managers/Internal/CoachMarkDisplayManager.swift - About 45 mins to fix

        Function hide has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            func hide(coachMarkView: UIView, from coachMark: CoachMark, at index: Int,
              animated: Bool, beforeTransition: Bool, completion: (() -> Void)? = nil) {
        guard let overlay = overlayManager else { return }

        guard animated else {
        Severity: Minor
        Found in Sources/Instructions/Managers/Internal/CoachMarkDisplayManager.swift - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function showNew has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            func showNew(coachMarkView: CoachMarkView, from coachMark: CoachMark,
                 at index: Int, animated: Bool = true, completion: (() -> Void)? = nil) {
        Severity: Minor
        Found in Sources/Instructions/Managers/Internal/CoachMarkDisplayManager.swift - About 35 mins to fix

          Function generateAndEnableVerticalConstraints has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              private func generateAndEnableVerticalConstraints(of coachMarkView: CoachMarkView,
                                                      forDisplayIn parentView: UIView,
                                                      usingCoachMark coachMark: CoachMark,
                                                      cutoutPath: UIBezierPath,
                                                      andOverlayView overlayView: OverlayView) {
          Severity: Minor
          Found in Sources/Instructions/Managers/Internal/CoachMarkDisplayManager.swift - About 35 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if transitionManager.animationType == .regular {
            UIView.animate(withDuration: transitionManager.parameters.duration,
                           delay: transitionManager.parameters.delay,
                           options: transitionManager.parameters.options,
                           animations: animationBlock, completion: completionBlock)
            Severity: Major
            Found in Sources/Instructions/Managers/Internal/CoachMarkDisplayManager.swift and 1 other location - About 1 hr to fix
            Sources/Instructions/Managers/Internal/CoachMarkDisplayManager.swift on lines 180..190

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 83.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if transitionManager.animationType == .regular {
            UIView.animate(withDuration: transitionManager.parameters.duration,
                           delay: transitionManager.parameters.delay,
                           options: transitionManager.parameters.options,
                           animations: animationBlock, completion: completionBlock)
            Severity: Major
            Found in Sources/Instructions/Managers/Internal/CoachMarkDisplayManager.swift and 1 other location - About 1 hr to fix
            Sources/Instructions/Managers/Internal/CoachMarkDisplayManager.swift on lines 106..116

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 83.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status