Sign upLogin

ephread/Instructions

View on GitHub
Star

Showing 32 of 63 total issues

Function update has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        coachMark: inout CoachMark,
        usingFrame frame: CGRect? = nil,
        pointOfInterest: CGPoint?,
        superview: UIView? = nil,
        cutoutPathMaker: CutoutPathMaker? = nil
Severity: Minor
Found in Sources/Instructions/Helpers/Public/CoachMarkHelper.swift - About 35 mins to fix

    Function hide has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        func hide(coachMark: CoachMark, at index: Int, animated: Bool = true,
              beforeTransition: Bool = false, completion: (() -> Void)? = nil) {
    Severity: Minor
    Found in Sources/Instructions/Core/Internal/CoachMarksViewController.swift - About 35 mins to fix

      Function showNew has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          func showNew(coachMarkView: CoachMarkView, from coachMark: CoachMark,
                 at index: Int, animated: Bool = true, completion: (() -> Void)? = nil) {
      Severity: Minor
      Found in Sources/Instructions/Managers/Internal/CoachMarkDisplayManager.swift - About 35 mins to fix

        Function generateAndEnableVerticalConstraints has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private func generateAndEnableVerticalConstraints(of coachMarkView: CoachMarkView,
                                                      forDisplayIn parentView: UIView,
                                                      usingCoachMark coachMark: CoachMark,
                                                      cutoutPath: UIBezierPath,
                                                      andOverlayView overlayView: OverlayView) {
        Severity: Minor
        Found in Sources/Instructions/Managers/Internal/CoachMarkDisplayManager.swift - About 35 mins to fix

          Function constraints has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  for coachMarkView: CoachMarkView,
        coachMark: CoachMark,
        parentView: UIView,
        layoutDirection: UIUserInterfaceLayoutDirection? = nil,
        passNumber: Int = 0
          Severity: Minor
          Found in Sources/Instructions/Helpers/Internal/CoachMarkLayoutHelper.swift - About 35 mins to fix

            Function makeDefaultCoachViews has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    withArrow arrow: Bool = true,
        arrowOrientation: CoachMarkArrowOrientation? = .top,
        hintText: String,
        nextText: String? = nil,
        nextLabelPosition: CoachMarkNextLabelPosition = .trailing
            Severity: Minor
            Found in Sources/Instructions/Helpers/Public/CoachMarkHelper.swift - About 35 mins to fix

              Function computeHorizontalAlignment has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  private func computeHorizontalAlignment(
        of coachMark: CoachMark,
        forLayoutDirection layoutDirection: UIUserInterfaceLayoutDirection,
        inFrame frame: CGRect
    ) -> CoachMarkHorizontalAlignment {
              Severity: Minor
              Found in Sources/Instructions/Helpers/Internal/CoachMarkLayoutHelper.swift - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this function.
              Open

                              return hitView
              Severity: Major
              Found in Sources/Instructions/Views/OverlayView.swift - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return hitView
                Severity: Major
                Found in Sources/Instructions/Views/OverlayView.swift - About 30 mins to fix

                  Function updateTopConstant has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      func updateTopConstant(from original: CGFloat) -> CGFloat {
#if !INSTRUCTIONS_APP_EXTENSIONS
        if #available(iOS 13.0, *) {
            let statusBarManager = UIApplication.shared.activeScene?.statusBarManager
                  Severity: Minor
                  Found in Sources/Instructions/Managers/Internal/SkipViewDisplayManager.swift - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function resume has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public func resume() {
        if isStarted && isPaused {
            isPaused = false

            let completion: (Bool) -> Void = { _ in
                  Severity: Minor
                  Found in Sources/Instructions/Managers/Public/FlowManager.swift - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function stopFlow has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      internal func stopFlow(immediately: Bool = false, userDidSkip skipped: Bool = false,
                           shouldCallDelegate: Bool = true, completion: (() -> Void)? = nil) {
        reset()

        let animationBlock = { () -> Void in
                  Severity: Minor
                  Found in Sources/Instructions/Managers/Public/FlowManager.swift - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language