epoberezkin/ajv

View on GitHub
lib/core.ts

Summary

Maintainability
F
4 days
Test Coverage

File core.ts has 765 lines of code (exceeds 250 allowed). Consider refactoring.
Open

export {
  Format,
  FormatDefinition,
  AsyncFormatDefinition,
  KeywordDefinition,
Severity: Major
Found in lib/core.ts - About 1 day to fix

    Ajv has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    export default class Ajv {
      opts: InstanceOptions
      errors?: ErrorObject[] | null // errors from the last validation
      logger: Logger
      // shared external scope values for compiled functions
    Severity: Minor
    Found in lib/core.ts - About 2 hrs to fix

      Function compileAsync has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

        compileAsync<T = unknown>(
          schema: AnySchemaObject,
          meta?: boolean
        ): Promise<AnyValidateFunction<T>> {
          if (typeof this.opts.loadSchema != "function") {
      Severity: Minor
      Found in lib/core.ts - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function compileAsync has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        compileAsync<T = unknown>(
          schema: AnySchemaObject,
          meta?: boolean
        ): Promise<AnyValidateFunction<T>> {
          if (typeof this.opts.loadSchema != "function") {
      Severity: Minor
      Found in lib/core.ts - About 1 hr to fix

        Function _addSchema has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

          _addSchema(
            schema: AnySchema,
            meta?: boolean,
            baseId?: string,
            validateSchema = this.opts.validateSchema,
        Severity: Minor
        Found in lib/core.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function $dataMetaSchema has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

          $dataMetaSchema(metaSchema: AnySchemaObject, keywordsJsonPointers: string[]): AnySchemaObject {
            const rules = this.RULES.all
            metaSchema = JSON.parse(JSON.stringify(metaSchema))
            for (const jsonPointer of keywordsJsonPointers) {
              const segments = jsonPointer.split("/").slice(1) // first segment is an empty string
        Severity: Minor
        Found in lib/core.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function addKeyword has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          addKeyword(
            kwdOrDef: string | KeywordDefinition,
            def?: KeywordDefinition // deprecated
          ): Ajv {
            let keyword: string | string[]
        Severity: Minor
        Found in lib/core.ts - About 1 hr to fix

          Function removeSchema has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            removeSchema(schemaKeyRef?: AnySchema | string | RegExp): Ajv {
              if (schemaKeyRef instanceof RegExp) {
                this._removeAllSchemas(this.schemas, schemaKeyRef)
                this._removeAllSchemas(this.refs, schemaKeyRef)
                return this
          Severity: Minor
          Found in lib/core.ts - About 1 hr to fix

            Function addKeyword has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

              addKeyword(
                kwdOrDef: string | KeywordDefinition,
                def?: KeywordDefinition // deprecated
              ): Ajv {
                let keyword: string | string[]
            Severity: Minor
            Found in lib/core.ts - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function validateSchema has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              validateSchema(schema: AnySchema, throwOrLogError?: boolean): boolean | Promise<unknown> {
                if (typeof schema == "boolean") return true
                let $schema: string | AnySchemaObject | undefined
                $schema = schema.$schema
                if ($schema !== undefined && typeof $schema != "string") {
            Severity: Minor
            Found in lib/core.ts - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _removeAllSchemas has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              private _removeAllSchemas(schemas: {[Ref in string]?: SchemaEnv | string}, regex?: RegExp): void {
                for (const keyRef in schemas) {
                  const sch = schemas[keyRef]
                  if (!regex || regex.test(keyRef)) {
                    if (typeof sch == "string") {
            Severity: Minor
            Found in lib/core.ts - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function addSchema has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              addSchema(
                schema: AnySchema | AnySchema[], // If array is passed, `key` will be ignored
                key?: string, // Optional schema key. Can be passed to `validate` method instead of schema object or id/ref. One schema per instance can have empty `id` and `key`.
                _meta?: boolean, // true if schema is a meta-schema. Used internally, addMetaSchema should be used instead.
                _validateSchema = this.opts.validateSchema // false to skip schema validation. Used internally, option validateSchema should be used instead.
            Severity: Minor
            Found in lib/core.ts - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function checkOptions has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              this: Ajv,
              checkOpts: OptionsInfo<RemovedOptions | DeprecatedOptions>,
              options: Options & RemovedOptions,
              msg: string,
              log: "warn" | "error" = "error"
            Severity: Minor
            Found in lib/core.ts - About 35 mins to fix

              Function removeSchema has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                removeSchema(schemaKeyRef?: AnySchema | string | RegExp): Ajv {
                  if (schemaKeyRef instanceof RegExp) {
                    this._removeAllSchemas(this.schemas, schemaKeyRef)
                    this._removeAllSchemas(this.refs, schemaKeyRef)
                    return this
              Severity: Minor
              Found in lib/core.ts - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function addRule has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              function addRule(
                this: Ajv,
                keyword: string,
                definition?: AddedKeywordDefinition,
                dataType?: JSONType
              Severity: Minor
              Found in lib/core.ts - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

              export {
                Format,
                FormatDefinition,
                AsyncFormatDefinition,
                KeywordDefinition,
              Severity: Major
              Found in lib/core.ts and 2 other locations - About 3 hrs to fix
              lib/ajv.ts on lines 40..60
              lib/jtd.ts on lines 101..121

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 99.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status