Sign upLogin

erikras/redux-form

View on GitHub
Star

Showing 125 of 125 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

const defaultShouldValidate = ({
  values,
  nextProps,
  // props,  // not used in default implementation
  initialRender,
Severity: Minor
Found in src/defaultShouldValidate.js and 2 other locations - About 40 mins to fix
src/defaultShouldError.js on lines 15..31
src/defaultShouldWarn.js on lines 15..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

const defaultShouldWarn = ({
  values,
  nextProps,
  // props,  // not used in default implementation
  initialRender,
Severity: Minor
Found in src/defaultShouldWarn.js and 2 other locations - About 40 mins to fix
src/defaultShouldError.js on lines 15..31
src/defaultShouldValidate.js on lines 15..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

const defaultShouldError = ({
  values,
  nextProps,
  // props,  // not used in default implementation
  initialRender,
Severity: Minor
Found in src/defaultShouldError.js and 2 other locations - About 40 mins to fix
src/defaultShouldValidate.js on lines 15..31
src/defaultShouldWarn.js on lines 15..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    return {
      pass,
      message: () =>
        this.utils.matcherHint('.toEqualMap') +
        '\n\n' +
Severity: Minor
Found in src/structure/plain/__tests__/expectations.js and 1 other location - About 35 mins to fix
src/structure/plain/__tests__/expectations.js on lines 50..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('should remove submit errors', () => {
    const state = reducer(
      fromJS({
        foo: {
          registeredFields: { bar: { name: 'bar', type: 'field', count: 1 } },
Severity: Minor
Found in src/__tests__/helpers/reducer.unregisterField.js and 1 other location - About 35 mins to fix
src/__tests__/helpers/reducer.unregisterField.js on lines 197..212

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    return {
      pass,
      message: () =>
        this.utils.matcherHint('.toContainExactly') +
        '\n\n' +
Severity: Minor
Found in src/structure/plain/__tests__/expectations.js and 1 other location - About 35 mins to fix
src/structure/plain/__tests__/expectations.js on lines 31..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('should remove async errors', () => {
    const state = reducer(
      fromJS({
        foo: {
          registeredFields: { bar: { name: 'bar', type: 'field', count: 1 } },
Severity: Minor
Found in src/__tests__/helpers/reducer.unregisterField.js and 1 other location - About 35 mins to fix
src/__tests__/helpers/reducer.unregisterField.js on lines 158..173

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

  return {
    ...state,
    [first]: next
  }
Severity: Major
Found in src/structure/plain/setIn.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

      if (React.isValidElement(obj) || React.isValidElement(other)) return false
    Severity: Major
    Found in src/structure/plain/deepEqual.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return value
      Severity: Major
      Found in src/events/getValue.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

          return props
        Severity: Major
        Found in src/createFieldProps.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return state
          Severity: Major
          Found in src/structure/plain/deleteIn.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return state
            Severity: Major
            Found in src/structure/plain/deleteIn.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return !keys(registeredFields)
        .filter(name => getIn(registeredFields, `['${name}'].count`) > 0)
        .some(name =>
          hasError(getIn(registeredFields, `['${name}']`), syncErrors, asyncErrors, submitErrors)
        )
              Severity: Major
              Found in src/selectors/isValid.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return copy
                Severity: Major
                Found in src/structure/plain/deleteIn.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                    return state
                  Severity: Major
                  Found in src/structure/plain/deleteIn.js - About 30 mins to fix

                    Similar blocks of code found in 4 locations. Consider refactoring.
                    Open

                        mergeWith<T: Object, A: Object, B: Object>(
      object: T,
      s1: A,
      s2: B,
      customizer?: (
                    Severity: Major
                    Found in flow-typed/npm/lodash_v4.x.x.js and 3 other locations - About 30 mins to fix
                    flow-typed/npm/lodash_v4.x.x.js on lines 989..1000
                    flow-typed/npm/lodash_v4.x.x.js on lines 1040..1051
                    flow-typed/npm/lodash_v4.x.x.js on lines 1107..1118

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 100.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 4 locations. Consider refactoring.
                    Open

                        assignWith<T: Object, A: Object, B: Object>(
      object: T,
      s1: A,
      s2: B,
      customizer?: (
                    Severity: Major
                    Found in flow-typed/npm/lodash_v4.x.x.js and 3 other locations - About 30 mins to fix
                    flow-typed/npm/lodash_v4.x.x.js on lines 989..1000
                    flow-typed/npm/lodash_v4.x.x.js on lines 1107..1118
                    flow-typed/npm/lodash_v4.x.x.js on lines 1211..1222

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 100.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Avoid too many return statements within this function.
                    Open

                          return getSelectedValues(event.target.options)
                    Severity: Major
                    Found in src/events/getValue.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                        return copy
                      Severity: Major
                      Found in src/structure/plain/splice.js - About 30 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language