ernestwisniewski/kbin

View on GitHub
src/Controller/Api/Entry/EntriesRetrieveApi.php

Summary

Maintainability
F
2 wks
Test Coverage

File EntriesRetrieveApi.php has 636 lines of code (exceeds 250 allowed). Consider refactoring.
Invalid

<?php

// SPDX-FileCopyrightText: 2023 /kbin contributors <https://kbin.pub/>
//
// SPDX-License-Identifier: AGPL-3.0-only
Severity: Major
Found in src/Controller/Api/Entry/EntriesRetrieveApi.php - About 1 day to fix

    Method __invoke has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            #[MapEntity(id: 'entry_id')]
            Entry $entry,
            EntryFactory $factory,
            EventDispatcherInterface $dispatcher,
            RateLimiterFactory $apiReadLimiter,
    Severity: Minor
    Found in src/Controller/Api/Entry/EntriesRetrieveApi.php - About 35 mins to fix

      Method collection has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              EntryRepository $repository,
              EntryFactory $factory,
              RequestStack $request,
              RateLimiterFactory $apiReadLimiter,
              RateLimiterFactory $anonymousApiReadLimiter,
      Severity: Minor
      Found in src/Controller/Api/Entry/EntriesRetrieveApi.php - About 35 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            #[OA\Response(
                response: 200,
                description: 'Returns a list of entries from subscribed magazines',
                content: new OA\JsonContent(
                    type: 'object',
        Severity: Major
        Found in src/Controller/Api/Entry/EntriesRetrieveApi.php and 2 other locations - About 3 days to fix
        src/Controller/Api/Entry/EntriesRetrieveApi.php on lines 403..536
        src/Controller/Api/Entry/EntriesRetrieveApi.php on lines 538..671

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 732.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            #[OA\Response(
                response: 200,
                description: 'Returns a list of entries from moderated magazines',
                content: new OA\JsonContent(
                    type: 'object',
        Severity: Major
        Found in src/Controller/Api/Entry/EntriesRetrieveApi.php and 2 other locations - About 3 days to fix
        src/Controller/Api/Entry/EntriesRetrieveApi.php on lines 268..401
        src/Controller/Api/Entry/EntriesRetrieveApi.php on lines 538..671

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 732.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            #[OA\Response(
                response: 200,
                description: 'Returns a list of favourited entries',
                content: new OA\JsonContent(
                    type: 'object',
        Severity: Major
        Found in src/Controller/Api/Entry/EntriesRetrieveApi.php and 2 other locations - About 3 days to fix
        src/Controller/Api/Entry/EntriesRetrieveApi.php on lines 268..401
        src/Controller/Api/Entry/EntriesRetrieveApi.php on lines 403..536

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 732.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            #[OA\Response(
                response: 200,
                description: 'Returns the Entry',
                content: new Model(type: EntryResponseDto::class),
                headers: [
        Severity: Major
        Found in src/Controller/Api/Entry/EntriesRetrieveApi.php and 1 other location - About 2 days to fix
        src/Controller/Api/Post/PostsRetrieveApi.php on lines 35..116

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 432.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status