Sign upLogin

ernestwisniewski/kbin

View on GitHub
Star
src/Controller/Api/Magazine/MagazineRetrieveApi.php

Summary

Maintainability
F
1 wk
Test Coverage

File MagazineRetrieveApi.php has 749 lines of code (exceeds 250 allowed). Consider refactoring.
Invalid

<?php

// SPDX-FileCopyrightText: 2023 /kbin contributors <https://kbin.pub/>
//
// SPDX-License-Identifier: AGPL-3.0-only
Severity: Major
Found in src/Controller/Api/Magazine/MagazineRetrieveApi.php - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        #[OA\Response(
        response: 200,
        description: 'Returns a paginated list of user\'s subscribed magazines',
        content: new OA\JsonContent(
            type: 'object',
    Severity: Major
    Found in src/Controller/Api/Magazine/MagazineRetrieveApi.php and 1 other location - About 3 days to fix
    src/Controller/Api/User/UserRetrieveApi.php on lines 437..560

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 699.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        #[OA\Response(
        response: 200,
        description: 'Returns a paginated list of blocked magazines',
        content: new OA\JsonContent(
            type: 'object',
    Severity: Major
    Found in src/Controller/Api/Magazine/MagazineRetrieveApi.php and 3 other locations - About 3 days to fix
    src/Controller/Api/Magazine/MagazineRetrieveApi.php on lines 337..443
    src/Controller/Api/User/UserRetrieveApi.php on lines 791..897
    src/Controller/Api/User/UserRetrieveApi.php on lines 899..1005

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 589.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        #[OA\Response(
        response: 200,
        description: 'Returns a paginated list of subscribed magazines',
        content: new OA\JsonContent(
            type: 'object',
    Severity: Major
    Found in src/Controller/Api/Magazine/MagazineRetrieveApi.php and 3 other locations - About 3 days to fix
    src/Controller/Api/Magazine/MagazineRetrieveApi.php on lines 678..784
    src/Controller/Api/User/UserRetrieveApi.php on lines 791..897
    src/Controller/Api/User/UserRetrieveApi.php on lines 899..1005

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 589.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        #[OA\Response(
        response: 200,
        description: 'Returns the magazine for the given name',
        content: new Model(type: MagazineResponseDto::class),
        headers: [
    Severity: Major
    Found in src/Controller/Api/Magazine/MagazineRetrieveApi.php and 1 other location - About 1 day to fix
    src/Controller/Api/User/UserRetrieveApi.php on lines 112..188

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 406.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        #[OA\Response(
        response: 200,
        description: 'Returns the Magazine',
        content: new Model(type: MagazineResponseDto::class),
        headers: [
    Severity: Major
    Found in src/Controller/Api/Magazine/MagazineRetrieveApi.php and 2 other locations - About 1 day to fix
    src/Controller/Api/Domain/DomainRetrieveApi.php on lines 34..110
    src/Controller/Api/User/UserRetrieveApi.php on lines 34..110

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 400.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status