Sign upLogin

ernestwisniewski/kbin

View on GitHub
Star
src/Controller/Api/OAuth2/CreateClientApi.php

Summary

Maintainability
D
2 days
Test Coverage

File CreateClientApi.php has 304 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

// SPDX-FileCopyrightText: 2023 /kbin contributors <https://kbin.pub/>
//
// SPDX-License-Identifier: AGPL-3.0-only
Severity: Minor
Found in src/Controller/Api/OAuth2/CreateClientApi.php - About 3 hrs to fix

    Method __invoke has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        #[OA\Response(
        response: 201,
        description: 'Returns the created oauth2 client. Be sure to save the identifier and secret since these will be how you obtain tokens for the API.',
        content: new Model(type: OAuth2ClientDto::class, groups: ['created', 'common']),
        headers: [
    Severity: Major
    Found in src/Controller/Api/OAuth2/CreateClientApi.php - About 2 hrs to fix

      Method uploadImage has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          #[OA\Response(
        response: 201,
        description: 'Returns the created oauth2 client. Be sure to save the identifier and secret since these will be how you obtain tokens for the API.',
        content: new Model(type: OAuth2ClientDto::class, groups: ['Default', 'created', 'common']),
        headers: [
      Severity: Minor
      Found in src/Controller/Api/OAuth2/CreateClientApi.php - About 1 hr to fix

        Method __invoke has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                ClientManagerInterface $manager,
        ClientFactory $clientFactory,
        UserCreate $userCreate,
        UserRepository $userRepository,
        SettingsManager $settingsManager,
        Severity: Major
        Found in src/Controller/Api/OAuth2/CreateClientApi.php - About 1 hr to fix

          Function uploadImage has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              #[OA\Response(
        response: 201,
        description: 'Returns the created oauth2 client. Be sure to save the identifier and secret since these will be how you obtain tokens for the API.',
        content: new Model(type: OAuth2ClientDto::class, groups: ['Default', 'created', 'common']),
        headers: [
          Severity: Minor
          Found in src/Controller/Api/OAuth2/CreateClientApi.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function __invoke has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              #[OA\Response(
        response: 201,
        description: 'Returns the created oauth2 client. Be sure to save the identifier and secret since these will be how you obtain tokens for the API.',
        content: new Model(type: OAuth2ClientDto::class, groups: ['created', 'common']),
        headers: [
          Severity: Minor
          Found in src/Controller/Api/OAuth2/CreateClientApi.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method uploadImage has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  ClientManagerInterface $manager,
        ClientFactory $clientFactory,
        UserCreate $userCreate,
        UserRepository $userRepository,
        SettingsManager $settingsManager,
          Severity: Major
          Found in src/Controller/Api/OAuth2/CreateClientApi.php - About 50 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (false !== array_search('client_credentials', $dto->grants)) {
            if ($userRepository->findOneByUsername($dto->username)) {
                throw new BadRequestHttpException('That username/email is taken!');
            }
            if ($userRepository->findOneBy(['email' => $dto->contactEmail])) {
            Severity: Major
            Found in src/Controller/Api/OAuth2/CreateClientApi.php and 1 other location - About 4 hrs to fix
            src/Controller/Api/OAuth2/CreateClientApi.php on lines 322..339

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 181.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (false !== array_search('client_credentials', $dto->grants)) {
            if ($userRepository->findOneByUsername($dto->username)) {
                throw new BadRequestHttpException('That username/email is taken!');
            }
            if ($userRepository->findOneBy(['email' => $dto->contactEmail])) {
            Severity: Major
            Found in src/Controller/Api/OAuth2/CreateClientApi.php and 1 other location - About 4 hrs to fix
            src/Controller/Api/OAuth2/CreateClientApi.php on lines 156..173

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 181.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status