ernestwisniewski/kbin

View on GitHub
src/Controller/Post/PostFrontController.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method magazine has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function magazine(
        Magazine $magazine,
        ?string $sortBy,
        ?string $time,
        PostRepository $repository,
Severity: Minor
Found in src/Controller/Post/PostFrontController.php - About 1 hr to fix

    Method subscribed has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        #[IsGranted('ROLE_USER')]
        public function subscribed(?string $sortBy, ?string $time, PostRepository $repository, Request $request): Response
        {
            $user = $this->getUserOrThrow();
    
    
    Severity: Minor
    Found in src/Controller/Post/PostFrontController.php - About 1 hr to fix

      Method front has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function front(?string $sortBy, ?string $time, PostRepository $repository, Request $request): Response
          {
              $user = $this->getUser();
      
              $criteria = new PostPageView($this->getPageNb($request));
      Severity: Minor
      Found in src/Controller/Post/PostFrontController.php - About 1 hr to fix

        Method magazine has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                Magazine $magazine,
                ?string $sortBy,
                ?string $time,
                PostRepository $repository,
                Request $request
        Severity: Minor
        Found in src/Controller/Post/PostFrontController.php - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Invalid

              #[IsGranted('ROLE_USER')]
              public function moderated(?string $sortBy, ?string $time, PostRepository $repository, Request $request): Response
              {
                  $criteria = new PostPageView($this->getPageNb($request));
                  $criteria->showSortOption($criteria->resolveSort($sortBy))
          Severity: Major
          Found in src/Controller/Post/PostFrontController.php and 1 other location - About 7 hrs to fix
          src/Controller/Post/PostFrontController.php on lines 139..172

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 238.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Invalid

              #[IsGranted('ROLE_USER')]
              public function favourite(?string $sortBy, ?string $time, PostRepository $repository, Request $request): Response
              {
                  $criteria = new PostPageView($this->getPageNb($request));
                  $criteria->showSortOption($criteria->resolveSort($sortBy))
          Severity: Major
          Found in src/Controller/Post/PostFrontController.php and 1 other location - About 7 hrs to fix
          src/Controller/Post/PostFrontController.php on lines 104..137

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 238.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status