ernestwisniewski/kbin

View on GitHub
src/Entity/Magazine.php

Summary

Maintainability
A
3 hrs
Test Coverage
D
63%

File Magazine.php has 356 lines of code (exceeds 250 allowed). Consider refactoring.
Invalid

<?php

// SPDX-FileCopyrightText: 2023 /kbin contributors <https://kbin.pub/>
//
// SPDX-License-Identifier: AGPL-3.0-only
Severity: Minor
Found in src/Entity/Magazine.php - About 4 hrs to fix

    Magazine has 31 functions (exceeds 20 allowed). Consider refactoring.
    Invalid

    #[Entity(repositoryClass: MagazineRepository::class)]
    #[Index(columns: ['visibility', 'is_adult'], name: 'magazine_visibility_adult_idx')]
    #[Index(columns: ['visibility'], name: 'magazine_visibility_idx')]
    #[Index(columns: ['is_adult'], name: 'magazine_adult_idx')]
    #[Index(columns: ['ap_id'], name: 'magazine_ap_id_idx')]
    Severity: Minor
    Found in src/Entity/Magazine.php - About 3 hrs to fix

      Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              string $name,
              string $title,
              User $user,
              ?string $description,
              ?string $rules,
      Severity: Major
      Found in src/Entity/Magazine.php - About 50 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            public function unsubscribe(User $user): void
            {
                $criteria = Criteria::create()
                    ->where(Criteria::expr()->eq('user', $user));
        
        
        Severity: Major
        Found in src/Entity/Magazine.php and 2 other locations - About 1 hr to fix
        src/Entity/Category.php on lines 111..125
        src/Entity/Domain.php on lines 117..131

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 101.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function userIsOwner(User $user): bool
            {
                $user->moderatorTokens->get(-1);
        
                $criteria = Criteria::create()
        Severity: Minor
        Found in src/Entity/Magazine.php and 1 other location - About 35 mins to fix
        src/Entity/Magazine.php on lines 174..183

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function userIsModerator(User $user): bool
            {
                $user->moderatorTokens->get(-1);
        
                $criteria = Criteria::create()
        Severity: Minor
        Found in src/Entity/Magazine.php and 1 other location - About 35 mins to fix
        src/Entity/Magazine.php on lines 185..194

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status