Sign upLogin

ernestwisniewski/kbin

View on GitHub
Star
src/Service/ActivityPubManager.php

Summary

Maintainability
D
2 days
Test Coverage

File ActivityPubManager.php has 347 lines of code (exceeds 250 allowed). Consider refactoring.
Invalid

<?php

// SPDX-FileCopyrightText: 2023 /kbin contributors <https://kbin.pub/>
//
// SPDX-License-Identifier: AGPL-3.0-only
Severity: Minor
Found in src/Service/ActivityPubManager.php - About 4 hrs to fix

    Function findActorOrCreate has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
    Open

        public function findActorOrCreate(string $actorUrlOrHandle): null|User|Magazine
    {
        if (str_contains($actorUrlOrHandle, $this->settingsManager->get('KBIN_DOMAIN').'/m/')) {
            $magazine = str_replace('https://'.$this->settingsManager->get('KBIN_DOMAIN').'/m/', '', $actorUrlOrHandle);
    Severity: Minor
    Found in src/Service/ActivityPubManager.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 17 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            private Server $server,
        private UserRepository $userRepository,
        private UserCreate $userCreate,
        private UserFactory $userFactory,
        private MagazineCreate $magazineCreate,
    Severity: Major
    Found in src/Service/ActivityPubManager.php - About 2 hrs to fix

      Method findActorOrCreate has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function findActorOrCreate(string $actorUrlOrHandle): null|User|Magazine
    {
        if (str_contains($actorUrlOrHandle, $this->settingsManager->get('KBIN_DOMAIN').'/m/')) {
            $magazine = str_replace('https://'.$this->settingsManager->get('KBIN_DOMAIN').'/m/', '', $actorUrlOrHandle);
      Severity: Minor
      Found in src/Service/ActivityPubManager.php - About 1 hr to fix

        Method updateUser has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function updateUser(string $actorUrl): User
    {
        $user = $this->userRepository->findOneBy(['apProfileId' => $actorUrl]);

        $actor = $this->apHttpClient->getActorObject($actorUrl);
        Severity: Minor
        Found in src/Service/ActivityPubManager.php - About 1 hr to fix

          Method updateMagazine has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function updateMagazine(string $actorUrl): Magazine
    {
        $magazine = $this->magazineRepository->findOneBy(['apProfileId' => $actorUrl]);
        $actor = $this->apHttpClient->getActorObject($actorUrl);
          Severity: Minor
          Found in src/Service/ActivityPubManager.php - About 1 hr to fix

            Function handleImages has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                public function handleImages(array $attachment): ?Image
    {
        $images = array_filter(
            $attachment,
            fn ($val) => \in_array($val['type'], ['Document', 'Image']) && ImageManager::isImageUrl($val['url'])
            Severity: Minor
            Found in src/Service/ActivityPubManager.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function updateUser has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function updateUser(string $actorUrl): User
    {
        $user = $this->userRepository->findOneBy(['apProfileId' => $actorUrl]);

        $actor = $this->apHttpClient->getActorObject($actorUrl);
            Severity: Minor
            Found in src/Service/ActivityPubManager.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function createCcFromBody has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function createCcFromBody(string $body): array
    {
        $mentions = $this->mentionManager->extract($body) ?? [];

        $urls = [];
            Severity: Minor
            Found in src/Service/ActivityPubManager.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                    return null;
            Severity: Major
            Found in src/Service/ActivityPubManager.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return $magazine;
              Severity: Major
              Found in src/Service/ActivityPubManager.php - About 30 mins to fix

                Function updateMagazine has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function updateMagazine(string $actorUrl): Magazine
    {
        $magazine = $this->magazineRepository->findOneBy(['apProfileId' => $actorUrl]);
        $actor = $this->apHttpClient->getActorObject($actorUrl);
                Severity: Minor
                Found in src/Service/ActivityPubManager.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if ('Person' === $actor['type']) {
            // User
            $user = $this->userRepository->findOneBy(['apProfileId' => $actorUrl]);
            if (!$user) {
                $user = $this->createUser($actorUrl);
                Severity: Major
                Found in src/Service/ActivityPubManager.php and 1 other location - About 1 hr to fix
                src/Service/ActivityPubManager.php on lines 153..168

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 119.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if ('Group' === $actor['type']) {
            // User
            $magazine = $this->magazineRepository->findOneBy(['apProfileId' => $actorUrl]);
            if (!$magazine) {
                $magazine = $this->createMagazine($actorUrl);
                Severity: Major
                Found in src/Service/ActivityPubManager.php and 1 other location - About 1 hr to fix
                src/Service/ActivityPubManager.php on lines 135..150

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 119.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status