Sign upLogin

erxes/erxes

View on GitHub
Star
api/src/__tests__/automationMutation.test.ts

Summary

Maintainability
D
1 day
Test Coverage

File automationMutation.test.ts has 366 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import './setup.ts';

import * as faker from 'faker';

import AutomationsAPI from '../data/dataSources/automations';
Severity: Minor
Found in api/src/__tests__/automationMutation.test.ts - About 4 hrs to fix

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

        createAutomationSpy.mockImplementation(() => {
      return {
        ...args,
        _id: faker.random.uuid(),
        createdAt: new Date(),
    Severity: Major
    Found in api/src/__tests__/automationMutation.test.ts and 2 other locations - About 1 hr to fix
    api/src/__tests__/automationMutation.test.ts on lines 96..105
    api/src/__tests__/automationMutation.test.ts on lines 419..428

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 73.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

        createAutomationSpy.mockImplementation(() => {
      return {
        ...args,
        _id: faker.random.uuid(),
        createdAt: new Date(),
    Severity: Major
    Found in api/src/__tests__/automationMutation.test.ts and 2 other locations - About 1 hr to fix
    api/src/__tests__/automationMutation.test.ts on lines 365..374
    api/src/__tests__/automationMutation.test.ts on lines 419..428

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 73.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

        createAutomationSpy.mockImplementation(() => {
      return {
        ...args,
        _id: faker.random.uuid(),
        createdAt: new Date(),
    Severity: Major
    Found in api/src/__tests__/automationMutation.test.ts and 2 other locations - About 1 hr to fix
    api/src/__tests__/automationMutation.test.ts on lines 96..105
    api/src/__tests__/automationMutation.test.ts on lines 365..374

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 73.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        const args = {
      _id: faker.random.word(),
      automationId: faker.random.word(),
      triggerId: faker.random.word(),
      description: faker.random.word()
    Severity: Major
    Found in api/src/__tests__/automationMutation.test.ts and 1 other location - About 1 hr to fix
    api/src/__tests__/automationMutation.test.ts on lines 230..235

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 72.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        const args = {
      _id: faker.random.word(),
      automationId: faker.random.word(),
      triggerId: faker.random.word(),
      description: faker.random.word()
    Severity: Major
    Found in api/src/__tests__/automationMutation.test.ts and 1 other location - About 1 hr to fix
    api/src/__tests__/automationMutation.test.ts on lines 292..297

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 72.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        const args = {
      automationId: faker.random.word(),
      triggerId: faker.random.word(),
      description: faker.random.word()
    };
    Severity: Major
    Found in api/src/__tests__/automationMutation.test.ts and 5 other locations - About 1 hr to fix
    api/src/__tests__/httpEndpoints.test.ts on lines 83..87
    api/src/__tests__/integrationDb.test.ts on lines 452..456
    api/src/__tests__/integrationMutations.test.ts on lines 159..163
    api/src/__tests__/knowledgeBaseMutations.test.ts on lines 32..36
    api/src/__tests__/pipelineLabelMutations.test.ts on lines 40..44

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status