Sign upLogin

erxes/erxes

View on GitHub
Star
api/src/__tests__/boardQueries.test.ts

Summary

Maintainability
D
3 days
Test Coverage

File boardQueries.test.ts has 728 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import * as sinon from 'sinon';
import { graphqlRequest } from '../db/connection';
import {
  boardFactory,
  conversationFactory,
Severity: Major
Found in api/src/__tests__/boardQueries.test.ts - About 1 day to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        test('When stackBy is stage', async () => {
      const response = await graphqlRequest(qry, 'itemsCountByAssignedUser', {
        type: BOARD_TYPES.DEAL,
        pipelineId: pipeline._id,
        stackBy: 'stage'
    Severity: Major
    Found in api/src/__tests__/boardQueries.test.ts and 3 other locations - About 1 hr to fix
    api/src/__tests__/boardQueries.test.ts on lines 869..877
    api/src/__tests__/boardQueries.test.ts on lines 879..887
    api/src/__tests__/boardQueries.test.ts on lines 901..909

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 71.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        test('When stackBy is label', async () => {
      const response = await graphqlRequest(qry, 'itemsCountByAssignedUser', {
        type: BOARD_TYPES.DEAL,
        pipelineId: pipeline._id,
        stackBy: 'label'
    Severity: Major
    Found in api/src/__tests__/boardQueries.test.ts and 3 other locations - About 1 hr to fix
    api/src/__tests__/boardQueries.test.ts on lines 859..867
    api/src/__tests__/boardQueries.test.ts on lines 869..877
    api/src/__tests__/boardQueries.test.ts on lines 901..909

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 71.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        test('When stackBy is dueDate', async () => {
      const response = await graphqlRequest(qry, 'itemsCountByAssignedUser', {
        type: BOARD_TYPES.DEAL,
        pipelineId: pipeline._id,
        stackBy: 'dueDate'
    Severity: Major
    Found in api/src/__tests__/boardQueries.test.ts and 3 other locations - About 1 hr to fix
    api/src/__tests__/boardQueries.test.ts on lines 859..867
    api/src/__tests__/boardQueries.test.ts on lines 869..877
    api/src/__tests__/boardQueries.test.ts on lines 879..887

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 71.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        test('When stackBy is priority', async () => {
      const response = await graphqlRequest(qry, 'itemsCountByAssignedUser', {
        type: BOARD_TYPES.DEAL,
        pipelineId: pipeline._id,
        stackBy: 'priority'
    Severity: Major
    Found in api/src/__tests__/boardQueries.test.ts and 3 other locations - About 1 hr to fix
    api/src/__tests__/boardQueries.test.ts on lines 859..867
    api/src/__tests__/boardQueries.test.ts on lines 879..887
    api/src/__tests__/boardQueries.test.ts on lines 901..909

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 71.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 23 locations. Consider refactoring.
    Open

      afterEach(async () => {
    // Clearing test data
    await Boards.deleteMany({});
    await Stages.deleteMany({});
    await Pipelines.deleteMany({});
    Severity: Major
    Found in api/src/__tests__/boardQueries.test.ts and 22 other locations - About 1 hr to fix
    api/src/__tests__/brandMutations.test.ts on lines 27..32
    api/src/__tests__/channelMutations.test.ts on lines 26..31
    api/src/__tests__/checklistDb.test.ts on lines 51..56
    api/src/__tests__/checklistMutations.test.ts on lines 34..39
    api/src/__tests__/companyMutations.test.ts on lines 51..56
    api/src/__tests__/conversationDb.test.ts on lines 37..42
    api/src/__tests__/fieldDb.test.ts on lines 24..29
    api/src/__tests__/fieldMutations.test.ts on lines 108..113
    api/src/__tests__/formMutations.test.ts on lines 38..43
    api/src/__tests__/importHistoryDb.test.ts on lines 7..12
    api/src/__tests__/knowledgeBaseQueries.test.ts on lines 17..22
    api/src/__tests__/notificationQueries.test.ts on lines 31..36
    api/src/__tests__/permissionMutations.test.ts on lines 46..51
    api/src/__tests__/permissionUtil.test.ts on lines 64..69
    api/src/__tests__/pipelineLabelMutations.test.ts on lines 55..60
    api/src/__tests__/productDb.test.ts on lines 31..36
    api/src/__tests__/productMutations.test.ts on lines 76..81
    api/src/__tests__/productQueries.test.ts on lines 15..20
    api/src/__tests__/tagMutations.test.ts on lines 47..52
    api/src/__tests__/userMutations.test.ts on lines 95..100
    api/src/__tests__/userQueries.test.ts on lines 16..21
    api/src/__tests__/widgetMutations.test.ts on lines 869..874

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        expect(response.taskUrl).toBe(
      `/task/board?_id=${taskBoard._id}&pipelineId=${taskPipeline._id}&itemId=${task._id}`
    );
    Severity: Major
    Found in api/src/__tests__/boardQueries.test.ts and 3 other locations - About 40 mins to fix
    api/src/__tests__/boardQueries.test.ts on lines 693..695
    api/src/__tests__/boardQueries.test.ts on lines 699..701
    api/src/__tests__/productDb.test.ts on lines 307..309

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        expect(response.dealUrl).toBe(
      `/deal/board?_id=${dealBoard._id}&pipelineId=${dealPipeline._id}&itemId=${deal._id}`
    );
    Severity: Major
    Found in api/src/__tests__/boardQueries.test.ts and 3 other locations - About 40 mins to fix
    api/src/__tests__/boardQueries.test.ts on lines 696..698
    api/src/__tests__/boardQueries.test.ts on lines 699..701
    api/src/__tests__/productDb.test.ts on lines 307..309

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        expect(response.ticketUrl).toBe(
      `/ticket/board?_id=${ticketBoard._id}&pipelineId=${ticketPipeline._id}&itemId=${ticket._id}`
    );
    Severity: Major
    Found in api/src/__tests__/boardQueries.test.ts and 3 other locations - About 40 mins to fix
    api/src/__tests__/boardQueries.test.ts on lines 693..695
    api/src/__tests__/boardQueries.test.ts on lines 696..698
    api/src/__tests__/productDb.test.ts on lines 307..309

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const mock = sinon.stub(elk, 'fetchElk').callsFake(() => {
      return Promise.resolve({ count: 1 });
    });
    Severity: Minor
    Found in api/src/__tests__/boardQueries.test.ts and 1 other location - About 35 mins to fix
    api/src/__tests__/conversationQueries.test.ts on lines 1533..1537

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status