Sign upLogin

erxes/erxes

View on GitHub
Star
api/src/__tests__/calendarMutations.test.ts

Summary

Maintainability
D
3 days
Test Coverage

File calendarMutations.test.ts has 473 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { IntegrationsAPI } from '../data/dataSources';
import { graphqlRequest } from '../db/connection';
import {
  calendarBoardFactory,
  calendarFactory,
Severity: Minor
Found in api/src/__tests__/calendarMutations.test.ts - About 7 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      test('Update schedule page', async () => {
    const mutation = `
      mutation editSchedulePage($_id: String!, ${pageParamsDef}) {
        editSchedulePage(_id: $_id, ${pageParams})
      }
    Severity: Major
    Found in api/src/__tests__/calendarMutations.test.ts and 1 other location - About 3 hrs to fix
    api/src/__tests__/calendarMutations.test.ts on lines 388..411

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 111.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      test('Update calendar event', async () => {
    const mutation = `
      mutation editCalendarEvent($_id: String!, ${eventParamDefs}) {
        editCalendarEvent(_id: $_id, ${eventParams})
      }
    Severity: Major
    Found in api/src/__tests__/calendarMutations.test.ts and 1 other location - About 3 hrs to fix
    api/src/__tests__/calendarMutations.test.ts on lines 518..542

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 111.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      test('Delete calendar event', async () => {
    const mutation = `
      mutation deleteCalendarEvent($_id: String!, $accountId: String!) {
        deleteCalendarEvent(_id: $_id, accountId: $accountId)
      }
    Severity: Major
    Found in api/src/__tests__/calendarMutations.test.ts and 1 other location - About 3 hrs to fix
    api/src/__tests__/calendarMutations.test.ts on lines 438..461

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      test('Update account calendar', async () => {
    const mutation = `
      mutation editAccountCalendar($_id: String!, $name: String, $color: String, $show: Boolean) {
        editAccountCalendar(_id: $_id, name: $name, color: $color, show: $show)
      }
    Severity: Major
    Found in api/src/__tests__/calendarMutations.test.ts and 1 other location - About 3 hrs to fix
    api/src/__tests__/calendarMutations.test.ts on lines 413..436

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 14 locations. Consider refactoring.
    Open

      afterEach(async () => {
    // Clearing test data
    await Users.deleteMany({});
    await Calendars.deleteMany({});
    await CalendarGroups.deleteMany({});
    Severity: Major
    Found in api/src/__tests__/calendarMutations.test.ts and 13 other locations - About 1 hr to fix
    api/src/__tests__/boardDb.test.ts on lines 52..58
    api/src/__tests__/calendarDb.test.ts on lines 25..31
    api/src/__tests__/calendarQueries.test.ts on lines 33..39
    api/src/__tests__/customerMutations.test.ts on lines 108..114
    api/src/__tests__/dealDb.test.ts on lines 51..57
    api/src/__tests__/dealQueries.test.ts on lines 148..154
    api/src/__tests__/engageMessageDb.test.ts on lines 250..256
    api/src/__tests__/growthHackDb.test.ts on lines 36..42
    api/src/__tests__/integrationQueries.test.ts on lines 68..74
    api/src/__tests__/taskDb.test.ts on lines 36..42
    api/src/__tests__/ticketDb.test.ts on lines 36..42
    api/src/__tests__/widgetMutations.test.ts on lines 72..78
    api/src/__tests__/widgetQueries.test.ts on lines 33..39

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 70.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        try {
      await graphqlRequest(mutation, 'calendarsAdd', args, { dataSources: {} });
    } catch (e) {
      expect(e).toBeDefined();
    }
    Severity: Minor
    Found in api/src/__tests__/calendarMutations.test.ts and 2 other locations - About 35 mins to fix
    api/src/__tests__/conversationMutations.test.ts on lines 514..525
    api/src/__tests__/conversationMutations.test.ts on lines 570..581

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status