Sign upLogin

erxes/erxes

View on GitHub
Star
api/src/__tests__/companyMutations.test.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  test('Merge company', async () => {
    const args = {
      companyIds: [_company._id],
      companyFields: {
        primaryName: faker.company.companyName()
Severity: Major
Found in api/src/__tests__/companyMutations.test.ts and 1 other location - About 3 hrs to fix
api/src/__tests__/customerMutations.test.ts on lines 219..243

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 23 locations. Consider refactoring.
Open

  afterEach(async () => {
    // Clearing test data
    await Companies.deleteMany({});
    await Customers.deleteMany({});
    await Users.deleteMany({});
Severity: Major
Found in api/src/__tests__/companyMutations.test.ts and 22 other locations - About 1 hr to fix
api/src/__tests__/boardQueries.test.ts on lines 92..97
api/src/__tests__/brandMutations.test.ts on lines 27..32
api/src/__tests__/channelMutations.test.ts on lines 26..31
api/src/__tests__/checklistDb.test.ts on lines 51..56
api/src/__tests__/checklistMutations.test.ts on lines 34..39
api/src/__tests__/conversationDb.test.ts on lines 37..42
api/src/__tests__/fieldDb.test.ts on lines 24..29
api/src/__tests__/fieldMutations.test.ts on lines 108..113
api/src/__tests__/formMutations.test.ts on lines 38..43
api/src/__tests__/importHistoryDb.test.ts on lines 7..12
api/src/__tests__/knowledgeBaseQueries.test.ts on lines 17..22
api/src/__tests__/notificationQueries.test.ts on lines 31..36
api/src/__tests__/permissionMutations.test.ts on lines 46..51
api/src/__tests__/permissionUtil.test.ts on lines 64..69
api/src/__tests__/pipelineLabelMutations.test.ts on lines 55..60
api/src/__tests__/productDb.test.ts on lines 31..36
api/src/__tests__/productMutations.test.ts on lines 76..81
api/src/__tests__/productQueries.test.ts on lines 15..20
api/src/__tests__/tagMutations.test.ts on lines 47..52
api/src/__tests__/userMutations.test.ts on lines 95..100
api/src/__tests__/userQueries.test.ts on lines 16..21
api/src/__tests__/widgetMutations.test.ts on lines 869..874

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  beforeEach(async () => {
    // Creating test data
    _company = await companyFactory({});
    _user = await userFactory({});
Severity: Major
Found in api/src/__tests__/companyMutations.test.ts and 2 other locations - About 1 hr to fix
api/src/__tests__/emailTemplateMutations.test.ts on lines 22..28
api/src/__tests__/responseTemplateMutations.test.ts on lines 30..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    const company = await companyFactory({
      ownerId: _user._id,
      mergedIds: [_company._id],
      tagIds: [tag._id]
    });
Severity: Minor
Found in api/src/__tests__/companyMutations.test.ts and 1 other location - About 30 mins to fix
api/src/__tests__/growthHackQueries.test.ts on lines 200..204

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status