Sign upLogin

erxes/erxes

View on GitHub
Star
api/src/__tests__/configQueries.test.ts

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    try {
      await graphqlRequest(qry, 'configsCheckActivateInstallation', {
        hostname: 'localhost'
      });
    } catch (e) {
Severity: Minor
Found in api/src/__tests__/configQueries.test.ts and 1 other location - About 55 mins to fix
api/src/__tests__/widgetQueries.test.ts on lines 238..244

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    const mock = sinon.stub(utils, 'sendRequest').callsFake(() => {
      return Promise.resolve({ packageVersion: '-' });
    });
Severity: Major
Found in api/src/__tests__/configQueries.test.ts and 11 other locations - About 35 mins to fix
integrations/src/__tests__/facebook.test.ts on lines 127..129
integrations/src/__tests__/facebook.test.ts on lines 159..161
integrations/src/__tests__/facebook.test.ts on lines 224..226
integrations/src/__tests__/facebook.test.ts on lines 265..267
integrations/src/__tests__/facebook.test.ts on lines 300..302
integrations/src/__tests__/gmailLoginMiddleware.ts on lines 79..85
integrations/src/__tests__/nylasController.test.ts on lines 774..776
integrations/src/__tests__/twitter.test.ts on lines 85..87
integrations/src/__tests__/twitter.test.ts on lines 135..137
integrations/src/__tests__/twitter.test.ts on lines 207..209
integrations/src/__tests__/twitter.test.ts on lines 266..268

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status