Sign upLogin

erxes/erxes

View on GitHub
Star
api/src/__tests__/customerMutations.test.ts

Summary

Maintainability
C
1 day
Test Coverage

File customerMutations.test.ts has 273 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import * as faker from 'faker';
import * as sinon from 'sinon';
import * as utils from '../data/utils';
import { graphqlRequest } from '../db/connection';
import {
Severity: Minor
Found in api/src/__tests__/customerMutations.test.ts - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      test('Merge customer', async () => {
    const params = {
      customerIds: [_customer._id],
      customerFields: {
        firstName: faker.name.firstName()
    Severity: Major
    Found in api/src/__tests__/customerMutations.test.ts and 1 other location - About 3 hrs to fix
    api/src/__tests__/companyMutations.test.ts on lines 208..234

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 109.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      beforeEach(async () => {
    // Creating test data
    integration = await integrationFactory();
    _user = await userFactory({});
    _customer = await customerFactory({ integrationId: integration._id });
    Severity: Major
    Found in api/src/__tests__/customerMutations.test.ts and 1 other location - About 2 hrs to fix
    api/src/__tests__/segmentMutations.test.ts on lines 44..51

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 76.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 14 locations. Consider refactoring.
    Open

      afterEach(async () => {
    // Clearing test data
    await Users.deleteMany({});
    await Customers.deleteMany({});
    await Brands.deleteMany({});
    Severity: Major
    Found in api/src/__tests__/customerMutations.test.ts and 13 other locations - About 1 hr to fix
    api/src/__tests__/boardDb.test.ts on lines 52..58
    api/src/__tests__/calendarDb.test.ts on lines 25..31
    api/src/__tests__/calendarMutations.test.ts on lines 32..38
    api/src/__tests__/calendarQueries.test.ts on lines 33..39
    api/src/__tests__/dealDb.test.ts on lines 51..57
    api/src/__tests__/dealQueries.test.ts on lines 148..154
    api/src/__tests__/engageMessageDb.test.ts on lines 250..256
    api/src/__tests__/growthHackDb.test.ts on lines 36..42
    api/src/__tests__/integrationQueries.test.ts on lines 68..74
    api/src/__tests__/taskDb.test.ts on lines 36..42
    api/src/__tests__/ticketDb.test.ts on lines 36..42
    api/src/__tests__/widgetMutations.test.ts on lines 72..78
    api/src/__tests__/widgetQueries.test.ts on lines 33..39

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 70.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status