Sign upLogin

erxes/erxes

View on GitHub
Star
api/src/__tests__/dealDb.test.ts

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  test('Watch deal', async () => {
    await Deals.watchDeal(deal._id, true, user._id);

    const watchedDeal = await Deals.getDeal(deal._id);
Severity: Major
Found in api/src/__tests__/dealDb.test.ts and 4 other locations - About 6 hrs to fix
api/src/__tests__/boardDb.test.ts on lines 464..477
api/src/__tests__/growthHackDb.test.ts on lines 82..95
api/src/__tests__/taskDb.test.ts on lines 100..113
api/src/__tests__/ticketDb.test.ts on lines 99..112

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 155.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  test('Create deal Error(`Already converted a deal`)', async () => {
    const conversation = await conversationFactory();

    const args = {
      stageId: deal.stageId,
Severity: Major
Found in api/src/__tests__/dealDb.test.ts and 1 other location - About 5 hrs to fix
api/src/__tests__/taskDb.test.ts on lines 68..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 142.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  test('Update deal', async () => {
    const dealStageId = 'fakeId';
    const updatedDeal = await Deals.updateDeal(deal._id, {
      stageId: dealStageId
    });
Severity: Major
Found in api/src/__tests__/dealDb.test.ts and 3 other locations - About 3 hrs to fix
api/src/__tests__/growthHackDb.test.ts on lines 68..80
api/src/__tests__/taskDb.test.ts on lines 89..98
api/src/__tests__/ticketDb.test.ts on lines 88..97

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 18 locations. Consider refactoring.
Open

  test('Get deal', async () => {
    try {
      await Deals.getDeal('fakeId');
    } catch (e) {
      expect(e.message).toBe('Deal not found');
Severity: Major
Found in api/src/__tests__/dealDb.test.ts and 17 other locations - About 2 hrs to fix
api/src/__tests__/boardDb.test.ts on lines 479..489
api/src/__tests__/checklistDb.test.ts on lines 58..68
api/src/__tests__/checklistDb.test.ts on lines 70..80
api/src/__tests__/companyDb.test.ts on lines 66..76
api/src/__tests__/conversationDb.test.ts on lines 44..56
api/src/__tests__/conversationDb.test.ts on lines 58..68
api/src/__tests__/customerDb.test.ts on lines 47..57
api/src/__tests__/dashboardDb.test.ts on lines 22..32
api/src/__tests__/emailTemplateDb.test.ts on lines 19..29
api/src/__tests__/engageMessageDb.test.ts on lines 66..76
api/src/__tests__/internalNoteDb.test.ts on lines 47..57
api/src/__tests__/responseTemplateDb.test.ts on lines 19..31
api/src/__tests__/segmentDb.test.ts on lines 69..79
api/src/__tests__/tagDb.test.ts on lines 29..39
api/src/__tests__/ticketDb.test.ts on lines 44..54
api/src/__tests__/userDb.test.ts on lines 26..36
api/src/__tests__/webhookDb.test.ts on lines 22..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  test('Test removeDeals()', async () => {
    await Deals.removeDeals([deal._id]);

    const removed = await Deals.findOne({ _id: deal._id });
Severity: Major
Found in api/src/__tests__/dealDb.test.ts and 2 other locations - About 1 hr to fix
api/src/__tests__/taskDb.test.ts on lines 115..121
api/src/__tests__/ticketDb.test.ts on lines 114..120

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 74.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

  afterEach(async () => {
    // Clearing test data
    await Boards.deleteMany({});
    await Pipelines.deleteMany({});
    await Stages.deleteMany({});
Severity: Major
Found in api/src/__tests__/dealDb.test.ts and 13 other locations - About 1 hr to fix
api/src/__tests__/boardDb.test.ts on lines 52..58
api/src/__tests__/calendarDb.test.ts on lines 25..31
api/src/__tests__/calendarMutations.test.ts on lines 32..38
api/src/__tests__/calendarQueries.test.ts on lines 33..39
api/src/__tests__/customerMutations.test.ts on lines 108..114
api/src/__tests__/dealQueries.test.ts on lines 148..154
api/src/__tests__/engageMessageDb.test.ts on lines 250..256
api/src/__tests__/growthHackDb.test.ts on lines 36..42
api/src/__tests__/integrationQueries.test.ts on lines 68..74
api/src/__tests__/taskDb.test.ts on lines 36..42
api/src/__tests__/ticketDb.test.ts on lines 36..42
api/src/__tests__/widgetMutations.test.ts on lines 72..78
api/src/__tests__/widgetQueries.test.ts on lines 33..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status