Sign upLogin

erxes/erxes

View on GitHub
Star
api/src/__tests__/dealQueries.test.ts

Summary

Maintainability
F
3 days
Test Coverage

File dealQueries.test.ts has 818 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import * as moment from 'moment';
import * as sinon from 'sinon';
import { graphqlRequest } from '../db/connection';
import {
  boardFactory,
Severity: Major
Found in api/src/__tests__/dealQueries.test.ts - About 1 day to fix

    Function generateProductsData has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const generateProductsData = async () => {
  const field1 = await fieldFactory({ contentType: 'product' });

  if (!field1) {
    throw new Error('Field not found');
    Severity: Minor
    Found in api/src/__tests__/dealQueries.test.ts - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        test('Deals total count', async () => {
    const stage = await stageFactory({});
    const currentUser = await userFactory({});

    const args = { stageId: stage._id };
      Severity: Major
      Found in api/src/__tests__/dealQueries.test.ts and 2 other locations - About 4 hrs to fix
      api/src/__tests__/taskQueries.test.ts on lines 173..193
      api/src/__tests__/ticketQueries.test.ts on lines 181..201

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 125.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

        afterEach(async () => {
    // Clearing test data
    await Boards.deleteMany({});
    await Pipelines.deleteMany({});
    await Stages.deleteMany({});
      Severity: Major
      Found in api/src/__tests__/dealQueries.test.ts and 13 other locations - About 1 hr to fix
      api/src/__tests__/boardDb.test.ts on lines 52..58
      api/src/__tests__/calendarDb.test.ts on lines 25..31
      api/src/__tests__/calendarMutations.test.ts on lines 32..38
      api/src/__tests__/calendarQueries.test.ts on lines 33..39
      api/src/__tests__/customerMutations.test.ts on lines 108..114
      api/src/__tests__/dealDb.test.ts on lines 51..57
      api/src/__tests__/engageMessageDb.test.ts on lines 250..256
      api/src/__tests__/growthHackDb.test.ts on lines 36..42
      api/src/__tests__/integrationQueries.test.ts on lines 68..74
      api/src/__tests__/taskDb.test.ts on lines 36..42
      api/src/__tests__/ticketDb.test.ts on lines 36..42
      api/src/__tests__/widgetMutations.test.ts on lines 72..78
      api/src/__tests__/widgetQueries.test.ts on lines 33..39

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          try {
      response = await graphqlRequest(qry, 'dealDetail', args, {
        user: currentUser
      });
    } catch (e) {
      Severity: Major
      Found in api/src/__tests__/dealQueries.test.ts and 1 other location - About 1 hr to fix
      api/src/__tests__/dealQueries.test.ts on lines 648..654

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          try {
      response = await graphqlRequest(qry, 'dealDetail', args, {
        user: currentUser
      });
    } catch (e) {
      Severity: Major
      Found in api/src/__tests__/dealQueries.test.ts and 1 other location - About 1 hr to fix
      api/src/__tests__/dealQueries.test.ts on lines 669..675

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status