Sign upLogin

erxes/erxes

View on GitHub
Star
api/src/__tests__/fieldDb.test.ts

Summary

Maintainability
D
1 day
Test Coverage

File fieldDb.test.ts has 400 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {
  customerFactory,
  fieldFactory,
  fieldGroupFactory,
  formFactory,
Severity: Minor
Found in api/src/__tests__/fieldDb.test.ts - About 5 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        try {
      await Fields.createField({
        contentType: 'form',
        contentTypeId: 'DFAFDFADS',
        text: 'text'
    Severity: Major
    Found in api/src/__tests__/fieldDb.test.ts and 1 other location - About 1 hr to fix
    api/src/__tests__/userDb.test.ts on lines 301..309

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 23 locations. Consider refactoring.
    Open

      afterEach(async () => {
    // Clearing test data
    await Forms.deleteMany({});
    await Fields.deleteMany({});
    await FieldsGroups.deleteMany({});
    Severity: Major
    Found in api/src/__tests__/fieldDb.test.ts and 22 other locations - About 1 hr to fix
    api/src/__tests__/boardQueries.test.ts on lines 92..97
    api/src/__tests__/brandMutations.test.ts on lines 27..32
    api/src/__tests__/channelMutations.test.ts on lines 26..31
    api/src/__tests__/checklistDb.test.ts on lines 51..56
    api/src/__tests__/checklistMutations.test.ts on lines 34..39
    api/src/__tests__/companyMutations.test.ts on lines 51..56
    api/src/__tests__/conversationDb.test.ts on lines 37..42
    api/src/__tests__/fieldMutations.test.ts on lines 108..113
    api/src/__tests__/formMutations.test.ts on lines 38..43
    api/src/__tests__/importHistoryDb.test.ts on lines 7..12
    api/src/__tests__/knowledgeBaseQueries.test.ts on lines 17..22
    api/src/__tests__/notificationQueries.test.ts on lines 31..36
    api/src/__tests__/permissionMutations.test.ts on lines 46..51
    api/src/__tests__/permissionUtil.test.ts on lines 64..69
    api/src/__tests__/pipelineLabelMutations.test.ts on lines 55..60
    api/src/__tests__/productDb.test.ts on lines 31..36
    api/src/__tests__/productMutations.test.ts on lines 76..81
    api/src/__tests__/productQueries.test.ts on lines 15..20
    api/src/__tests__/tagMutations.test.ts on lines 47..52
    api/src/__tests__/userMutations.test.ts on lines 95..100
    api/src/__tests__/userQueries.test.ts on lines 16..21
    api/src/__tests__/widgetMutations.test.ts on lines 869..874

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        try {
      await Fields.updateField(testField._id, { text: 'text' });
    } catch (e) {
      expect(e.message).toBe('Cant update this field');
    }
    Severity: Major
    Found in api/src/__tests__/fieldDb.test.ts and 1 other location - About 1 hr to fix
    api/src/__tests__/fieldDb.test.ts on lines 192..196

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        try {
      await Fields.updateField(testField._id, { text: 'text' });
    } catch (e) {
      expect(e.message).toBe('Cant update this field');
    }
    Severity: Major
    Found in api/src/__tests__/fieldDb.test.ts and 1 other location - About 1 hr to fix
    api/src/__tests__/fieldDb.test.ts on lines 156..160

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        try {
      await Fields.createField({ contentType: 'form', text: 'text' });
    } catch (e) {
      expect(e.message).toEqual('Content type id is required');
    }
    Severity: Major
    Found in api/src/__tests__/fieldDb.test.ts and 2 other locations - About 1 hr to fix
    integrations/src/__tests__/nylas.test.ts on lines 724..731
    integrations/src/__tests__/nylas.test.ts on lines 765..772

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        try {
      await Fields.updateFieldsVisible(field._id, '123321', false);
    } catch (e) {
      expect(e.message).toBe('Cant update this field');
    }
    Severity: Minor
    Found in api/src/__tests__/fieldDb.test.ts and 1 other location - About 50 mins to fix
    api/src/__tests__/fieldDb.test.ts on lines 334..338

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        try {
      await Fields.updateFieldsVisible(testField._id, '123321', false);
    } catch (e) {
      expect(e.message).toBe('Cant update this field');
    }
    Severity: Minor
    Found in api/src/__tests__/fieldDb.test.ts and 1 other location - About 50 mins to fix
    api/src/__tests__/fieldDb.test.ts on lines 352..356

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        try {
      await FieldsGroups.updateGroup(_fieldGroup._id, doc);
    } catch (e) {
      expect(e.message).toBe('Cant update this group');
    }
    Severity: Major
    Found in api/src/__tests__/fieldDb.test.ts and 4 other locations - About 45 mins to fix
    api/src/__tests__/integrationDb.test.ts on lines 182..186
    api/src/__tests__/productDb.test.ts on lines 135..139
    api/src/__tests__/productDb.test.ts on lines 258..262
    api/src/__tests__/productDb.test.ts on lines 273..277

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        try {
      await FieldsGroups.removeGroup(_fieldGroup._id);
    } catch (e) {
      expect(e.message).toBe('Cant update this group');
    }
    Severity: Major
    Found in api/src/__tests__/fieldDb.test.ts and 5 other locations - About 40 mins to fix
    api/src/__tests__/calendarDb.test.ts on lines 102..106
    api/src/__tests__/calendarDb.test.ts on lines 140..144
    api/src/__tests__/productDb.test.ts on lines 322..326
    api/src/__tests__/productTemplateDb.test.ts on lines 294..298
    api/src/__tests__/tagDb.test.ts on lines 234..238

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status